Skip to content

Commit

Permalink
fix warnings, only one is over in Cosmos.VS.Package that microsoft.Vi…
Browse files Browse the repository at this point in the history
…sualStudio.CommonIDE, Version=10.0.0.0 is missing
  • Loading branch information
Trivalik_cp authored and Trivalik_cp committed Nov 19, 2014
1 parent 0d48ff1 commit 1e11282
Show file tree
Hide file tree
Showing 11 changed files with 28 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<OutputPath>bin\Debug\</OutputPath>
<DefineConstants>DEBUG;TRACE</DefineConstants>
<DebugType>full</DebugType>
<PlatformTarget>AnyCPU</PlatformTarget>
<PlatformTarget>x86</PlatformTarget>
<CodeAnalysisUseTypeNameInSuppression>true</CodeAnalysisUseTypeNameInSuppression>
<CodeAnalysisModuleSuppressionsFile>GlobalSuppressions.cs</CodeAnalysisModuleSuppressionsFile>
<ErrorReport>prompt</ErrorReport>
Expand Down
9 changes: 7 additions & 2 deletions source2/MDbg4/src/debugger/corapi/Debugger.cs
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ public static class NativeMethods
]
public static extern bool CloseHandle(IntPtr handle);


[CLSCompliant(false)]
[
DllImport(ShimLibraryName, CharSet = CharSet.Unicode, PreserveSig = false)
]
Expand Down Expand Up @@ -605,6 +605,7 @@ public static extern bool QueryFullProcessImageName(ProcessSafeHandle hProcess,
StringBuilder lpExeName,
ref int lpdwSize);

[CLSCompliant(false)]
[
DllImport(Ole32LibraryName, PreserveSig = false)
]
Expand Down Expand Up @@ -909,6 +910,7 @@ public string GetRuntimeDirectory()
return sb.ToString();
}

[CLSCompliant(false)]
public ICorDebug GetLegacyICorDebugInterface()
{
Guid ifaceId = typeof(ICorDebug).GUID;
Expand Down Expand Up @@ -988,6 +990,7 @@ public CLRDebugging()
/// <param name="flags">Flags which have additional information about the CLR.
/// See ClrDebuggingProcessFlags for more details</param>
/// <returns>The CLR's debugging interface</returns>
[CLSCompliant(false)]
public CorProcess OpenVirtualProcess(ulong moduleBaseAddress,
ICorDebugDataTarget dataTarget,
ICLRDebuggingLibraryProvider libraryProvider,
Expand All @@ -1004,7 +1007,8 @@ public CorProcess OpenVirtualProcess(ulong moduleBaseAddress,

/// <summary>
/// Version of the above that doesn't throw exceptions on failure
/// </summary>
/// </summary>
[CLSCompliant(false)]
public int TryOpenVirtualProcess(ulong moduleBaseAddress,
ICorDebugDataTarget dataTarget,
ICLRDebuggingLibraryProvider libraryProvider,
Expand Down Expand Up @@ -1088,6 +1092,7 @@ public enum ClrDebuggingProcessFlags
/// This interface exposes the native pipeline architecture startup APIs
/// </summary>
[ComImport, InterfaceType(ComInterfaceType.InterfaceIsIUnknown), Guid("D28F3C5A-9634-4206-A509-477552EEFB10")]
[CLSCompliant(false)]
public interface ICLRDebugging
{
/// <summary>
Expand Down
2 changes: 2 additions & 0 deletions source2/MDbg4/src/debugger/corapi/MetadataLocator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace Microsoft.Samples.Debugging.MetaDataLocator
{
[ComImport, InterfaceType(ComInterfaceType.InterfaceIsIUnknown), Guid("7cef8ba9-2ef7-42bf-973f-4171474f87d9")]
[CLSCompliant(false)]
public interface ICorDebugMetaDataLocator //REM straighten this up later : IUnknown
{
void GetMetaData(
Expand All @@ -36,6 +37,7 @@ struct HResultConsts
public const uint E_Fail = 0x80004005;
}

[CLSCompliant(false)]
public void GetMetaData(string imagePath,
uint dwImageTimeStamp,
uint dwImageSize,
Expand Down
2 changes: 2 additions & 0 deletions source2/MDbg4/src/debugger/corapi/Process.cs
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ public void GetThreadContext(int threadId, IntPtr contextPtr, int context_size)
}

/* Get the INativeContext object for the given thread */
[CLSCompliant(false)]
public INativeContext GetThreadContext(int threadId)
{
INativeContext context = ContextAllocator.GenerateContext();
Expand All @@ -182,6 +183,7 @@ public void SetThreadContext(int threadId, IntPtr contextPtr, int context_size)
}

/* Set the INativeContext object for the given thread */
[CLSCompliant(false)]
public void SetThreadContext(int threadId, INativeContext context)
{
using (IContextDirectAccessor w = context.OpenForDirectAccess())
Expand Down
1 change: 1 addition & 0 deletions source2/MDbg4/src/debugger/corapi/RegisterSet.cs
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ public void GetThreadContext(IntPtr contextPtr, int contextSize)
/// Throws if unavailable or if NativeContextAllocator is not set.
/// </summary>
[DebuggerBrowsable(DebuggerBrowsableState.Never)] // Too expensive to eagerly browse in debugger.
[CLSCompliant(false)]
public INativeContext GetContext
{
get
Expand Down
7 changes: 6 additions & 1 deletion source2/MDbg4/src/debugger/corapi/StackWalk.cs
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,15 @@ public CorFrame Current

#region Get/Set Context

[CLSCompliant(false)]
public void GetThreadContext(ContextFlags flags, int contextBufferSize, out int contextSize, IntPtr contextBuffer)
{
uint uContextSize = 0;
m_sw.GetContext((uint)flags, (uint)contextBufferSize, out uContextSize, contextBuffer);
contextSize = (int)uContextSize;
}
}

[CLSCompliant(false)]
public INativeContext GetContext()
{
INativeContext context = ContextAllocator.GenerateContext();
Expand All @@ -117,6 +119,7 @@ public INativeContext GetContext()

// ClsComplaint version of GetThreadContext.
// Caller must ensure that the context is valid, and for the right architecture.
[CLSCompliant(false)]
public void GetContext(INativeContext context)
{
using (IContextDirectAccessor w = context.OpenForDirectAccess())
Expand Down Expand Up @@ -155,6 +158,7 @@ public void SetThreadContext ( CorDebugSetContextFlag flag, int contextSize, Int

// ClsComplaint version of SetThreadContext.
// Caller must ensure that the context is valid, and for the right architecture.
[CLSCompliant(false)]
public void SetContext(CorDebugSetContextFlag flag, INativeContext context)
{
using (IContextDirectAccessor w = context.OpenForDirectAccess())
Expand All @@ -165,6 +169,7 @@ public void SetContext(CorDebugSetContextFlag flag, INativeContext context)

#endregion // Get/Set Context

[CLSCompliant(false)]
protected ICorDebugStackWalk m_sw;
protected CorThread m_th;
protected CorFrame m_frame;
Expand Down
1 change: 1 addition & 0 deletions source2/MDbg4/src/debugger/corapi/Thread.cs
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public enum CorStackWalkType
public struct CorBlockingObject
{
public CorValue BlockingObject;
[CLSCompliant(false)]
public CorDebugBlockingReason BlockingReason;
public TimeSpan Timeout;
}
Expand Down
1 change: 1 addition & 0 deletions source2/MDbg4/src/debugger/corapi/Value.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ namespace Microsoft.Samples.Debugging.CorDebug
/** A value in the remote process. */
public class CorValue : WrapperBase
{
[CLSCompliant(false)]
public CorValue(ICorDebugValue value)
: base(value)
{
Expand Down
8 changes: 3 additions & 5 deletions source2/MDbg4/src/debugger/corapi/corapi.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,6 @@
<Compile Include="WrapperBase.cs" />
<Compile Include="..\..\VersionInfo.cs" />
</ItemGroup>
<ItemGroup>
<Reference Include="System">
<HintPath>..\..\..\..\..\..\..\..\..\..\..\..\..\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.dll</HintPath>
</Reference>
</ItemGroup>
<ItemGroup>
<None Include="..\..\mdbg.snk" />
<None Include="ReadMe.txt" />
Expand Down Expand Up @@ -165,6 +160,9 @@
<Name>raw</Name>
</ProjectReference>
</ItemGroup>
<ItemGroup>
<Reference Include="System" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSHARP.Targets" />
<PropertyGroup Condition="">
<PreBuildEvent>
Expand Down
8 changes: 3 additions & 5 deletions source2/MDbg4/src/debugger/raw/raw.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,6 @@
<Compile Include="WindowsImports.cs" />
<Compile Include="..\..\VersionInfo.cs" />
</ItemGroup>
<ItemGroup>
<Reference Include="System">
<HintPath>..\..\..\..\..\..\..\..\..\..\..\..\..\WINDOWS\Microsoft.NET\Framework\v2.0.50727\System.dll</HintPath>
</Reference>
</ItemGroup>
<ItemGroup>
<None Include="..\..\mdbg.snk" />
<None Include="ReadMe.txt" />
Expand Down Expand Up @@ -101,6 +96,9 @@
<Name>NativeDebugWrappers</Name>
</ProjectReference>
</ItemGroup>
<ItemGroup>
<Reference Include="System" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSHARP.Targets" />
<PropertyGroup Condition="">
<PreBuildEvent>
Expand Down
1 change: 1 addition & 0 deletions source2/VSIP/Cosmos.VS.Windows/Cosmos.VS.Windows.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<Prefer32Bit>false</Prefer32Bit>
<PlatformTarget>x86</PlatformTarget>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>pdbonly</DebugType>
Expand Down

0 comments on commit 1e11282

Please sign in to comment.