Skip to content

Commit

Permalink
Some doc links that did not work and travis validation of api-docs (#…
Browse files Browse the repository at this point in the history
…188)

* Some doc links that did not work and travis validation of api-docs
* Also validate the lagom module apidocs
* Hard to keep both scaladoc and the compiler happy but this seems to do the trick
  • Loading branch information
johanandren authored Jan 8, 2019
1 parent b39f663 commit 281ce56
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 9 deletions.
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ jobs:
- CMD=lagom-persistence-couchbase-scaladsl/multi-jvm:test
- env:
- CMD=docs/paradox
- env:
- CMD=root/doc

- stage: publish
script: sbt +publish
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ abstract class CouchbaseSession {
* @param indexName the name of the index.
* @param ignoreIfExist if a secondary index already exists with that name, an exception will be thrown unless this
* is set to true.
* @param fields the JSON fields to index - each can be either `String` or [[com.couchbase.client.java.query.dsl.Expression]]
* @return an [[java.util.concurrent.CompletionStage]] of true if the index was/will be effectively created, false
* @param fields the JSON fields to index - each can be either `String` or `com.couchbase.client.java.query.dsl.Expression`
* @return an `java.util.concurrent.CompletionStage` of true if the index was/will be effectively created, false
* if the index existed and ignoreIfExist is true. Completion of the CompletionStage does not guarantee the index
* is online and ready to be used.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ trait CouchbaseSession {
* @param ignoreIfExist if a secondary index already exists with that name, an exception will be thrown unless this
* is set to true.
* @param fields the JSON fields to index - each can be either `String` or [com.couchbase.client.java.query.dsl.Expression]
* @return an {@link scala.concurrent.Future} of true if the index was/will be effectively created, false
* @return a Future completed with true if the index was/will be effectively created, false
* if the index existed and ignoreIfExist is true. Completion of the future does not guarantee the index is online
* and ready to be used.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ private[lagom] class CouchbaseReadSideImpl @Inject()(
private val dispatcher = system.settings.config.getString("lagom.persistence.read-side.use-dispatcher")
private implicit val ec: MessageDispatcher = system.dispatchers.lookup(dispatcher)

override def builder[Event <: AggregateEvent[Event]](readSideId: String): ReadSideHandlerBuilder[Event] =
new ReadSideHandlerBuilder[Event] {
override def builder[Event <: AggregateEvent[Event]](
readSideId: String
): CouchbaseReadSide.ReadSideHandlerBuilder[Event] =
new CouchbaseReadSide.ReadSideHandlerBuilder[Event] {

type Handler[E] = CouchbaseReadSideHandler.Handler[E]

Expand All @@ -43,30 +45,30 @@ private[lagom] class CouchbaseReadSideImpl @Inject()(

override def setGlobalPrepare(
callback: JFunction[CouchbaseSession, CompletionStage[Done]]
): ReadSideHandlerBuilder[Event] = {
): CouchbaseReadSide.ReadSideHandlerBuilder[Event] = {
globalPrepareCallback = callback.apply
this
}

override def setPrepare(
callback: BiFunction[CouchbaseSession, AggregateEventTag[Event], CompletionStage[Done]]
): ReadSideHandlerBuilder[Event] = {
): CouchbaseReadSide.ReadSideHandlerBuilder[Event] = {
prepareCallback = callback.apply
this
}

override def setEventHandler[E <: Event](
eventClass: Class[E],
handler: CouchbaseReadSide.TriConsumer[CouchbaseSession, E, Offset, CompletionStage[Done]]
): ReadSideHandlerBuilder[Event] = {
): CouchbaseReadSide.ReadSideHandlerBuilder[Event] = {
handlers += (eventClass -> ((cs: CouchbaseSession, event: E, offset: Offset) => handler(cs, event, offset)))
this
}

override def setEventHandler[E <: Event](
eventClass: Class[E],
handler: BiFunction[CouchbaseSession, E, CompletionStage[Done]]
): ReadSideHandlerBuilder[Event] = {
): CouchbaseReadSide.ReadSideHandlerBuilder[Event] = {
handlers += (eventClass -> ((cs: CouchbaseSession, event: E, offset: Offset) => handler(cs, event)))
this
}
Expand Down

0 comments on commit 281ce56

Please sign in to comment.