expression: push down EXTRACT Duration to TiFlash (pingcap#39105)

ref pingcap#39104
wshwsh12 · Nov 16, 2022 · ce69f0b · ce69f0b
1 parent 154f027
commit ce69f0b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/expression/expr_to_pb_test.go b/expression/expr_to_pb_test.go
@@ -558,6 +558,14 @@ func TestExprPushDownToFlash(t *testing.T) {
 	require.NoError(t, err)
 	exprs = append(exprs, function)
 
+	// ExtractDuration
+	extractDurationUnitCol := new(Constant)
+	extractDurationUnitCol.Value = types.NewStringDatum("microsecond")
+	extractDurationUnitCol.RetType = types.NewFieldType(mysql.TypeString)
+	function, err = NewFunction(mock.NewContext(), ast.Extract, types.NewFieldType(mysql.TypeLonglong), extractDurationUnitCol, durationColumn)
+	require.NoError(t, err)
+	exprs = append(exprs, function)
+
 	// CastIntAsInt
 	function, err = NewFunction(mock.NewContext(), ast.Cast, types.NewFieldType(mysql.TypeLonglong), intColumn)
 	require.NoError(t, err)

diff --git a/expression/expression.go b/expression/expression.go
@@ -1227,7 +1227,7 @@ func scalarExprSupportedByFlash(function *ScalarFunction) bool {
 		}
 	case ast.Extract:
 		switch function.Function.PbCode() {
-		case tipb.ScalarFuncSig_ExtractDatetime:
+		case tipb.ScalarFuncSig_ExtractDatetime, tipb.ScalarFuncSig_ExtractDuration:
 			return true
 		}
 	case ast.Replace: