Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of deprecated methods of KeyStoreManager class #438

Conversation

UdeshAthukorala
Copy link
Contributor

Purpose

  • Remove the usage of deprecated methods of KeyStoreManager class

Part of: wso2/product-is#21206

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.34%. Comparing base (cab60a0) to head (6430089).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...on/identity/sso/saml/admin/SAMLSSOConfigAdmin.java 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #438      +/-   ##
============================================
- Coverage     45.36%   45.34%   -0.02%     
+ Complexity     1609     1441     -168     
============================================
  Files           116      116              
  Lines         10226    10225       -1     
  Branches       1305     1298       -7     
============================================
- Hits           4639     4637       -2     
- Misses         4947     4948       +1     
  Partials        640      640              
Flag Coverage Δ
unit 20.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@UdeshAthukorala UdeshAthukorala merged commit e9bb97a into wso2-extensions:master Feb 9, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants