Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OPA policy support #1193

Closed
wants to merge 3 commits into from
Closed

Add OPA policy support #1193

wants to merge 3 commits into from

Conversation

binodmx
Copy link
Contributor

@binodmx binodmx commented May 29, 2023

Purpose

This PR resolves #1164 by adding OPA policy config for API Policies. An OPA policy can be added by defining oPAPolicy property in APIPolicy kind. Following is an sample APIPolicy kind which includes a OPA policy.

apiVersion: dp.wso2.com/v1alpha1
kind: APIPolicy
metadata:
  name: sample-api-policy
  namespace: apk
spec:
  override:
    oPAPolicy:
      serverURL: http://opa-svc.apk:8181/v1/data
      policy: opa/test
      rule: allow
  targetRef:
    group: dp.wso2.com
    kind: API
    name: http-bin-api
    namespace: apk

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.18 ⚠️

Comparison is base (8aab219) 32.56% compared to head (5e4cd2f) 32.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
- Coverage   32.56%   32.38%   -0.18%     
==========================================
  Files         188      188              
  Lines       21795    21920     +125     
  Branches     7026     7100      +74     
==========================================
+ Hits         7097     7099       +2     
- Misses      14573    14696     +123     
  Partials      125      125              
Flag Coverage Δ
adapter 24.02% <ø> (-0.03%) ⬇️
admin-domain-service 52.40% <ø> (ø)
backoffice-domain-service 57.51% <ø> (-0.23%) ⬇️
devportal-domain-service 29.85% <ø> (-1.67%) ⬇️
idp-domain-service 80.10% <ø> (ø)
runtime-domain-service 32.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AmaliMatharaarachchi
Copy link
Contributor

we will be reopening this PR with the mediation app implementation. Hence we will be closing as we are expecting changes to these CRs in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OPA Policy
3 participants