This repository has been archived by the owner on Sep 5, 2021. It is now read-only.
Maintenance, bugfixes, and initial mobile support for WebViews/mobile devices. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @pages = Page.order("name").frontpage | ||
| render :layout => 'full_map' | ||
| # Is this coming from an Android WebView? | ||
| if request.headers['X-Requested-With'] or params[:mobile] == "1" |
There was a problem hiding this comment.
Does this logic mean that any request with an X-Requested-With header will get redirected to the mobile index?
There was a problem hiding this comment.
Whoops. That's not what I intended.
Would detecting the substring "Mobile Safari" in the user agent be a better idea?
|
Is this change staged anywhere I can preview what a mobile page looks like? |
|
I'll work on bringing a demo instance up. It's borderless. |
|
I can't get Dokku to play nice with shuttles at the moment. On my VM, it's the normal map without the borders. |
|
@bamnet, can you test this on your own Dokku instance? I'm not sure if it's an issue with Dokku or my specific instance of it. |
Use CSS media queries instead of user agent detection.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.