Lower media weight if catalognum exists #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release distance isn't lowered if it doesn't have a catalog number (as far as I can tell). If the media is removed, then if one release matches both the media and catalog number, and another has a non-matching media and doesn't have a catalog number, then the non-matching media wouldn't be penalized. For examples, this plugin chooses the cassette release for this album instead of the CD, even though both media and catalog number match in origin.yaml https://musicbrainz.org/release-group/05c73df7-423f-4dab-b600-afdc7d453e4e Instead, it might be good to lower the media weight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beets doesn't seem to penalized the match distance if a release is missing a catalog number (as far as I can tell but I could easily be wrong).
If, for example, a release has a CD and digital version, and the digital one is missing the catalog number, then if media is removed from the query because the origin file has a catalog number, both media and catalog number might end up being ignored.