Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up "Load into vimscript". #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Speed up "Load into vimscript". #275

wants to merge 1 commit into from

Conversation

xavierd
Copy link
Owner

@xavierd xavierd commented Feb 17, 2013

From 0.012s to 0.004s.

I'm using pyeval() in vim to avoid all the str() call in python. That way, no conversion is done. However, this requires an up to date vim, as noted in #270.

From 0.012s to 0.004s.
@tobiasgrosser
Copy link
Collaborator

I think it would be unfortunate to require everybody to compile their own vim versions. This adds a lot of overhead,
for a very limited benefit. My vim version supports threads very well and works flawless with the current clang_complete. The only missing featue is pyeval. I just tried this patch with a manual installation. It gives
a speedup from 0.007s to 0.004s. Given that I have an overall completion time of 0.138783, this does not make a big difference. From my point it seems we can get along very well without using pyeval. However, if you think the
speedup is still wanted, we can probably support both the old and the new vim at the same time. Your change request has only four changed lines. Making them conditional on the availability of pyeval should not be too involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants