GCP Observability: Add payload metrics (grpc#31899)

xcezx · Dec 15, 2022 · 5100b33 · 5100b33
1 parent a0f00f0
commit 5100b33
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 0 deletions.
diff --git a/include/grpcpp/opencensus.h b/include/grpcpp/opencensus.h
@@ -76,9 +76,17 @@ extern const absl::string_view kRpcServerStartedRpcsMeasureName;
 // Canonical gRPC view definitions.
 const ::opencensus::stats::ViewDescriptor& ClientStartedRpcs();
 const ::opencensus::stats::ViewDescriptor& ClientCompletedRpcs();
+const ::opencensus::stats::ViewDescriptor&
+ClientSentCompressedMessageBytesPerRpc();
+const ::opencensus::stats::ViewDescriptor&
+ClientReceivedCompressedMessageBytesPerRpc();
 
 const ::opencensus::stats::ViewDescriptor& ServerStartedRpcs();
 const ::opencensus::stats::ViewDescriptor& ServerCompletedRpcs();
+const ::opencensus::stats::ViewDescriptor&
+ServerSentCompressedMessageBytesPerRpc();
+const ::opencensus::stats::ViewDescriptor&
+ServerReceivedCompressedMessageBytesPerRpc();
 
 const ::opencensus::stats::ViewDescriptor& ClientSentMessagesPerRpcCumulative();
 const ::opencensus::stats::ViewDescriptor& ClientSentBytesPerRpcCumulative();

diff --git a/src/cpp/ext/filters/census/views.cc b/src/cpp/ext/filters/census/views.cc
@@ -110,6 +110,28 @@ const ViewDescriptor& ClientCompletedRpcs() {
   return descriptor;
 }
 
+const ViewDescriptor& ClientSentCompressedMessageBytesPerRpc() {
+  const static ViewDescriptor descriptor =
+      ViewDescriptor()
+          .set_name("grpc.io/client/sent_compressed_message_bytes_per_rpc")
+          .set_measure(kRpcClientSentBytesPerRpcMeasureName)
+          .set_aggregation(BytesDistributionAggregation())
+          .add_column(ClientMethodTagKey())
+          .add_column(ClientStatusTagKey());
+  return descriptor;
+}
+
+const ViewDescriptor& ClientReceivedCompressedMessageBytesPerRpc() {
+  const static ViewDescriptor descriptor =
+      ViewDescriptor()
+          .set_name("grpc.io/client/received_compressed_message_bytes_per_rpc")
+          .set_measure(kRpcClientReceivedBytesPerRpcMeasureName)
+          .set_aggregation(BytesDistributionAggregation())
+          .add_column(ClientMethodTagKey())
+          .add_column(ClientStatusTagKey());
+  return descriptor;
+}
+
 // server
 const ViewDescriptor& ServerStartedRpcs() {
   const static ViewDescriptor descriptor =
@@ -132,6 +154,28 @@ const ViewDescriptor& ServerCompletedRpcs() {
   return descriptor;
 }
 
+const ViewDescriptor& ServerSentCompressedMessageBytesPerRpc() {
+  const static ViewDescriptor descriptor =
+      ViewDescriptor()
+          .set_name("grpc.io/server/sent_compressed_message_bytes_per_rpc")
+          .set_measure(kRpcServerSentBytesPerRpcMeasureName)
+          .set_aggregation(BytesDistributionAggregation())
+          .add_column(ServerMethodTagKey())
+          .add_column(ServerStatusTagKey());
+  return descriptor;
+}
+
+const ViewDescriptor& ServerReceivedCompressedMessageBytesPerRpc() {
+  const static ViewDescriptor descriptor =
+      ViewDescriptor()
+          .set_name("grpc.io/server/received_compressed_message_bytes_per_rpc")
+          .set_measure(kRpcServerReceivedBytesPerRpcMeasureName)
+          .set_aggregation(BytesDistributionAggregation())
+          .add_column(ServerMethodTagKey())
+          .add_column(ServerStatusTagKey());
+  return descriptor;
+}
+
 // client cumulative
 const ViewDescriptor& ClientSentBytesPerRpcCumulative() {
   const static ViewDescriptor descriptor =

diff --git a/src/cpp/ext/gcp/observability.cc b/src/cpp/ext/gcp/observability.cc
@@ -61,9 +61,13 @@ void RegisterOpenCensusViewsForGcpObservability() {
   // Register client default views for GCP observability
   ClientStartedRpcs().RegisterForExport();
   ClientCompletedRpcs().RegisterForExport();
+  ClientSentCompressedMessageBytesPerRpc().RegisterForExport();
+  ClientReceivedCompressedMessageBytesPerRpc().RegisterForExport();
   // Register server default views for GCP observability
   ServerStartedRpcs().RegisterForExport();
   ServerCompletedRpcs().RegisterForExport();
+  ServerSentCompressedMessageBytesPerRpc().RegisterForExport();
+  ServerReceivedCompressedMessageBytesPerRpc().RegisterForExport();
 }
 
 }  // namespace