Makefile: git submodule detect and warn if out-of-sync #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a reoccuring issue that git submodule gets out-of-sync, which cause confusion and issues. End-user needs to run: git submodule update We cannot run this automatically, because there are legimite reasons for the submodule to be out-of-sync, e.g. when testing local changes. Thus, this patch detect SHA-1 doesn't match, and just warns end-users, together with a hint to call: git submodule update Signed-off-by: Jesper Dangaard Brouer <[email protected]>
It is a reoccuring issue that git submodule gets out-of-sync, which cause confusion and issues. End-user needs to run: git submodule update We cannot run this automatically, because there are legimite reasons for the submodule to be out-of-sync, e.g. when testing local changes. Thus, this patch detect SHA-1 doesn't match, and just warns end-users, together with a hint to call: git submodule update Signed-off-by: Jesper Dangaard Brouer <[email protected]>
|
Per discussion in PR #18 |
|
Erm, GitHub seems to think the commit is empty? |
LOL - It seems I forgot got call |
|
I fixed it in the stg branch, and ran |
|
Jesper Dangaard Brouer <[email protected]> writes:
I fixed it in the stg branch, and ran `stg publish` again. This
resulted in two commit's one empty and the new with same text and
contents. I'll try push a new branch, with a clean history.
No worries, I can squash those when merging; going to do a bit of
cleanup of the Makefile anyway :)
|
|
I will close this one, in favor of PR #21 |
astoycos
pushed a commit
to astoycos/xdp-tools
that referenced
this pull request
Nov 2, 2023
- Previous update broke CI git checkout - CI was not testing pushed code - Update makefile to build C code before uTests to fix error: "/usr/bin/ld: cannot find -lwrapper"
astoycos
pushed a commit
to astoycos/xdp-tools
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a reoccuring issue that git submodule gets out-of-sync, which cause confusion and issues.
End-user needs to run: git submodule update
We cannot run this automatically, because there are legimite reasons for the submodule to be out-of-sync, e.g. when testing local changes.
Thus, this patch detect SHA-1 doesn't match, and just warns end-users, together with a hint to call: git submodule update