plugin/hosts: fix data race on h.size (coredns#2573)

Guard the access of h.size as this is now a data race. Fixes coredns#2571 Signed-off-by: Miek Gieben <[email protected]>
xdu31 · Feb 17, 2019 · 6d21892 · 6d21892
1 parent 2743c8e
commit 6d21892
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/plugin/hosts/hostsfile.go b/plugin/hosts/hostsfile.go
@@ -129,7 +129,10 @@ func (h *Hostsfile) readHosts() {
 	defer file.Close()
 
 	stat, err := file.Stat()
-	if err == nil && h.mtime.Equal(stat.ModTime()) && h.size == stat.Size() {
+	h.RLock()
+	size := h.size
+	h.RUnlock()
+	if err == nil && h.mtime.Equal(stat.ModTime()) && size == stat.Size() {
 		return
 	}