Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed handling of PLY with vertex colors as uchar #1441

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixed handling of PLY with vertex colors as uchar #1441

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d822b7e
Fixed handling of PLY with vertex colors as uchar
Nov 17, 2023
487c522
rotated sphere to make vertex colors clearer
Nov 17, 2023
e2b018a
Changed PLY integer normalization to match Blender
Nov 17, 2023
07463ae
update comment
Nov 17, 2023
e9cb291
update comment
Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comment
  • Loading branch information
Eran Guendelman committed Nov 17, 2023
commit 07463ae39333d53284915a0a11e50af60e722739
3 changes: 2 additions & 1 deletion libs/yocto/yocto_modelio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,8 @@ inline T get_value(const ply_property& prop, size_t index) {
return 0;
}
// Assumes T is a floating point type, and any integral type will
// be divided by the max value of its unsigned counterpart.
// be divided by the max value of its type (matching behavior
// of Blender PLY import).
template <typename T>
inline T get_normalized_value(const ply_property& prop, size_t index) {
switch (prop.type) {
Expand Down