Skip to content

Commit

Permalink
perf: make the tests work in worktrees
Browse files Browse the repository at this point in the history
This patch makes perf-lib.sh more robust so that it can run correctly
even inside a worktree. For example, it assumed that $GIT_DIR/objects is
the objects directory (which is not the case for worktrees) and it used
the commondir file verbatim, even if it contained a relative path.

Furthermore, the setup code expected `git rev-parse --git-dir` to spit
out a relative path, which is also not true for worktrees. Let's just
change the code to accept both relative and absolute paths, by avoiding
the `cd` into the copied working directory.

Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
dscho authored and gitster committed May 13, 2016
1 parent fd9dbdf commit 7501b59
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions t/perf/perf-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,22 +80,22 @@ test_perf_create_repo_from () {
error "bug in the test script: not 2 parameters to test-create-repo"
repo="$1"
source="$2"
source_git=$source/$(cd "$source" && git rev-parse --git-dir)
source_git="$(git -C "$source" rev-parse --git-dir)"
objects_dir="$(git -C "$source" rev-parse --git-path objects)"
mkdir -p "$repo/.git"
(
cd "$repo/.git" &&
{ cp -Rl "$source_git/objects" . 2>/dev/null ||
cp -R "$source_git/objects" .; } &&
{ cp -Rl "$objects_dir" "$repo/.git/" 2>/dev/null ||
cp -R "$objects_dir" "$repo/.git/"; } &&
for stuff in "$source_git"/*; do
case "$stuff" in
*/objects|*/hooks|*/config)
*/objects|*/hooks|*/config|*/commondir)
;;
*)
cp -R "$stuff" . || exit 1
cp -R "$stuff" "$repo/.git/" || exit 1
;;
esac
done &&
cd .. &&
cd "$repo" &&
git init -q && {
test_have_prereq SYMLINKS ||
git config core.symlinks false
Expand Down

0 comments on commit 7501b59

Please sign in to comment.