Add default serializer for SelectionModifier in FindNext and FindPrevious #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(maybe I'm misunderstanding the problem?) |
|
Right! I changed it now for the |
|
@scholtzan this needs a rebase as well. |
|
@cmyr Done |
cmyr
reviewed
Jul 11, 2018
rust/core-lib/src/view.rs
Outdated
| self.find_next(text, false, wrap_around.unwrap_or(false), | ||
| allow_same.unwrap_or(false), | ||
| &modify_selection.unwrap_or(SelectionModifier::Set)), | ||
| self.find_next(text, false, wrap_around, allow_same, &modify_selection), |
There was a problem hiding this comment.
Ah I actually have one more nit while we're in here; by convention, we preface the names of functions that are directly handling RPCs with do_, so this should be do_find_next, and below should be do_selection_for_find, etc.
|
Great, thanks for the cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR for #704. I am not sure if it would make sense to have default serializers for
wrap_aroundandallow_sametoo?Currently, serde does not support default literals such as
false(serde-rs/serde#368) so it would be necessary to write some workaround with functions.