[FLINK-6107] Enable newline at EOF check in streaming checkstyle

xiaobabyLu · Apr 26, 2017 · bab816f · bab816f
1 parent 2581a7b
commit bab816f
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/...ng-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphUserHashHasher.java b/...ng-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphUserHashHasher.java
@@ -54,4 +54,4 @@ public Map<Integer, byte[]> traverseStreamGraphAndGenerateHashes(StreamGraph str
 
 		return hashResult;
 	}
-}
+}
diff --git a/...reaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/package-info.java b/...reaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/package-info.java
@@ -19,4 +19,4 @@
  * This package contains the operators that perform the stream transformations.
  * One or more operators are bundled into a "chain" and executed in a stream task. 
  */
-package org.apache.flink.streaming.runtime.operators;
+package org.apache.flink.streaming.runtime.operators;
diff --git a/...ing-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorStateHandles.java b/...ing-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorStateHandles.java
@@ -106,4 +106,4 @@ public int getOperatorChainIndex() {
 	private static <T> T getSafeItemAtIndexOrNull(List<T> list, int idx) {
 		return CollectionUtil.isNullOrEmpty(list) ? null : list.get(idx);
 	}
-}
+}
diff --git a/...k-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/package-info.java b/...k-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/package-info.java
@@ -24,4 +24,4 @@
  * <p>The tasks merely set up the distributed stream coordination and the checkpointing.
  * Internally, the tasks create one or more operators, perform the stream transformations.
  */
-package org.apache.flink.streaming.runtime.tasks;
+package org.apache.flink.streaming.runtime.tasks;
diff --git a/flink-streaming-java/src/test/resources/log4j.properties b/flink-streaming-java/src/test/resources/log4j.properties
@@ -24,4 +24,4 @@ log4j.rootLogger=OFF, console
 log4j.appender.console=org.apache.log4j.ConsoleAppender
 log4j.appender.console.target = System.err
 log4j.appender.console.layout=org.apache.log4j.PatternLayout
-log4j.appender.console.layout.ConversionPattern=%d{HH:mm:ss,SSS} %-5p %-60c %x - %m%n
+log4j.appender.console.layout.ConversionPattern=%d{HH:mm:ss,SSS} %-5p %-60c %x - %m%n
diff --git a/tools/maven/strict-checkstyle.xml b/tools/maven/strict-checkstyle.xml
@@ -35,10 +35,10 @@ This file is based on the checkstyle file of Apache Beam.
     <!--&lt;!&ndash; Checks that there are no tab characters in the file. &ndash;&gt;-->
   <!--</module>-->
 
-  <!--<module name="NewlineAtEndOfFile">-->
-    <!--&lt;!&ndash; windows can use \n\r vs \n, so enforce the most used one ie UNIx style &ndash;&gt;-->
-    <!--<property name="lineSeparator" value="lf" />-->
-  <!--</module>-->
+  <module name="NewlineAtEndOfFile">
+    <!-- windows can use \n\r vs \n, so enforce the most used one ie UNIx style -->
+    <property name="lineSeparator" value="lf" />
+  </module>
 
   <module name="RegexpSingleline">
     <!-- Checks that TODOs don't have stuff in parenthesis, e.g., username. -->
-Original file line number
+Diff line change
@@ Expand Up @@
     		return hashResult;
     	}
-    }
+    }