Log "task is null" instead of let worker died

* when task is null in transfer-fn, creating TaskMessage leads NPE
xilongfan · Apr 17, 2015 · 14477f4 · 14477f4
1 parent a7c8310
commit 14477f4
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/storm-core/src/clj/backtype/storm/daemon/worker.clj b/storm-core/src/clj/backtype/storm/daemon/worker.clj
@@ -133,8 +133,10 @@
                     (when (not (.get remoteMap node+port))
                       (.put remoteMap node+port (ArrayList.)))
                     (let [remote (.get remoteMap node+port)]
-                      (.add remote (TaskMessage. task (.serialize serializer tuple)))
-                     )))) 
+                      (if (not-nil? task)
+                        (.add remote (TaskMessage. task (.serialize serializer tuple)))
+                        (log-warn "Can't transfer tuple - task value is null. tuple information: " tuple))
+                     ))))
                 (local-transfer local)
                 (disruptor/publish transfer-queue remoteMap)
               ))]