Skip to content

Commit

Permalink
SPARK-3028. sparkEventToJson should support SparkListenerExecutorMetr…
Browse files Browse the repository at this point in the history
…ics...

...Update

Author: Sandy Ryza <[email protected]>

Closes apache#1961 from sryza/sandy-spark-3028 and squashes the following commits:

dccdff5 [Sandy Ryza] Fix compile error
f883ded [Sandy Ryza] SPARK-3028. sparkEventToJson should support SparkListenerExecutorMetricsUpdate
  • Loading branch information
sryza authored and pwendell committed Aug 15, 2014
1 parent fd9fcd2 commit 0afe5cb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ private[spark] class EventLoggingListener(
logEvent(event, flushLogger = true)
override def onApplicationEnd(event: SparkListenerApplicationEnd) =
logEvent(event, flushLogger = true)
// No-op because logging every update would be overkill
override def onExecutorMetricsUpdate(event: SparkListenerExecutorMetricsUpdate) { }

/**
* Stop logging events.
Expand Down
3 changes: 2 additions & 1 deletion core/src/main/scala/org/apache/spark/util/JsonProtocol.scala
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,9 @@ private[spark] object JsonProtocol {
case applicationEnd: SparkListenerApplicationEnd =>
applicationEndToJson(applicationEnd)

// Not used, but keeps compiler happy
// These aren't used, but keeps compiler happy
case SparkListenerShutdown => JNothing
case SparkListenerExecutorMetricsUpdate(_, _) => JNothing
}
}

Expand Down

0 comments on commit 0afe5cb

Please sign in to comment.