Remove ARC boilerplate in Crashpad

ARC is now enabled by default, so there’s no need to enforce it against files being put into non-ARC targets. Bug: chromium:1468376 Change-Id: I58bbb4d1736293a6e9977954ce932dcfe2bafa54 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4750419 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mark Mentovai <[email protected]>
xlabmedical · Aug 3, 2023 · 617429d · 617429d
1 parent ce7f0f1
commit 617429d
Show file tree

Hide file tree

Showing 18 changed files with 0 additions and 72 deletions.
diff --git a/client/crash_report_database_mac.mm b/client/crash_report_database_mac.mm
@@ -49,10 +49,6 @@
 #include "util/ios/scoped_background_task.h"
 #endif  // BUILDFLAG(IS_IOS)
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace crashpad {
 
 namespace {

diff --git a/client/crashpad_client_ios_test.mm b/client/crashpad_client_ios_test.mm
@@ -27,10 +27,6 @@
 #include "testing/platform_test.h"
 #include "util/thread/thread.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace crashpad {
 namespace test {
 namespace {

diff --git a/client/ios_handler/exception_processor.mm b/client/ios_handler/exception_processor.mm
@@ -54,10 +54,6 @@
 #include "client/annotation.h"
 #include "client/simulate_crash_ios.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace crashpad {
 
 namespace {

diff --git a/client/ios_handler/exception_processor_test.mm b/client/ios_handler/exception_processor_test.mm
@@ -19,10 +19,6 @@
 #include "gtest/gtest.h"
 #include "testing/platform_test.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace crashpad {
 namespace test {
 namespace {

diff --git a/test/ios/cptest_google_test_runner.mm b/test/ios/cptest_google_test_runner.mm
@@ -18,10 +18,6 @@
 #include "base/check.h"
 #import "test/ios/cptest_google_test_runner_delegate.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 @interface CPTestGoogleTestRunner : XCTestCase
 @end
 

diff --git a/test/ios/crash_type_xctest.mm b/test/ios/crash_type_xctest.mm
@@ -24,10 +24,6 @@
 #include "util/mach/exception_types.h"
 #include "util/mach/mach_extensions.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 @interface CPTestTestCase : XCTestCase {
   XCUIApplication* app_;
   CPTestSharedObject* rootObject_;

diff --git a/test/ios/google_test_setup.mm b/test/ios/google_test_setup.mm
@@ -20,10 +20,6 @@
 #include "gtest/gtest.h"
 #include "test/ios/cptest_google_test_runner_delegate.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 @interface UIApplication (Testing)
 - (void)_terminateWithStatus:(int)status;
 @end

diff --git a/test/ios/host/cptest_application_delegate.mm b/test/ios/host/cptest_application_delegate.mm
@@ -50,10 +50,6 @@
 #include "util/ios/raw_logging.h"
 #include "util/thread/thread.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 using OperationStatus = crashpad::CrashReportDatabase::OperationStatus;
 using Report = crashpad::CrashReportDatabase::Report;
 

diff --git a/test/ios/host/cptest_crash_view_controller.mm b/test/ios/host/cptest_crash_view_controller.mm
@@ -14,10 +14,6 @@
 
 #import "test/ios/host/cptest_crash_view_controller.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 @implementation CPTestCrashViewController
 
 - (void)loadView {

diff --git a/test/ios/host/main.mm b/test/ios/host/main.mm
@@ -16,10 +16,6 @@
 
 #import "test/ios/host/cptest_application_delegate.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 int main(int argc, char* argv[]) {
   NSString* appDelegateClassName;
   @autoreleasepool {

diff --git a/tools/mac/on_demand_service_tool.mm b/tools/mac/on_demand_service_tool.mm
@@ -30,10 +30,6 @@
 #include "util/mac/service_management.h"
 #include "util/stdlib/objc.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace crashpad {
 namespace {
 

diff --git a/util/ios/ios_system_data_collector.mm b/util/ios/ios_system_data_collector.mm
@@ -27,10 +27,6 @@
 #include "base/strings/sys_string_conversions.h"
 #include "build/build_config.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace {
 
 std::string ReadStringSysctlByName(const char* name) {

diff --git a/util/ios/scoped_background_task.mm b/util/ios/scoped_background_task.mm
@@ -16,10 +16,6 @@
 
 #import <Foundation/Foundation.h>
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace crashpad {
 namespace internal {
 

diff --git a/util/mac/launchd.mm b/util/mac/launchd.mm
@@ -23,10 +23,6 @@
 #include "base/strings/sys_string_conversions.h"
 #include "util/misc/implicit_cast.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace crashpad {
 
 launch_data_t CFPropertyToLaunchData(CFPropertyListRef property_cf) {

diff --git a/util/mac/launchd_test.mm b/util/mac/launchd_test.mm
@@ -28,10 +28,6 @@
 #include "gtest/gtest.h"
 #include "util/stdlib/objc.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace crashpad {
 namespace test {
 namespace {

diff --git a/util/mac/mac_util_test.mm b/util/mac/mac_util_test.mm
@@ -22,10 +22,6 @@
 #include "base/strings/stringprintf.h"
 #include "gtest/gtest.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace crashpad {
 namespace test {
 namespace {

diff --git a/util/mac/service_management_test.mm b/util/mac/service_management_test.mm
@@ -30,10 +30,6 @@
 #include "util/posix/process_info.h"
 #include "util/stdlib/objc.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 namespace crashpad {
 namespace test {
 namespace {

diff --git a/util/net/http_transport_mac.mm b/util/net/http_transport_mac.mm
@@ -28,10 +28,6 @@
 #include "util/misc/metrics.h"
 #include "util/net/http_body.h"
 
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
 // An implementation of NSInputStream that reads from a
 // crashpad::HTTPBodyStream.
 @interface CrashpadHTTPBodyStreamTransport : NSInputStream {