Skip to content

Commit

Permalink
Fix ci with dotnet-releaser when secrets are not available (bis)
Browse files Browse the repository at this point in the history
  • Loading branch information
xoofx committed Feb 28, 2022
1 parent b85ab65 commit fd54457
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
name: ci

env:
PROJECT_NAME: dotnet-releaser

on:
push:
paths-ignore:
Expand Down Expand Up @@ -34,4 +31,4 @@ jobs:
- name: Self Build - Publish (main only)
if: github.event_name == 'push'
run: |
./src/dotnet-releaser/bin/Debug/net6.0/dotnet-releaser run --nuget-token "${{secrets.NUGET_TOKEN}}" --github-token "${{secrets.GITHUB_TOKEN}}" src/dotnet-releaser.toml
./src/dotnet-releaser/bin/Debug/net6.0/dotnet-releaser run --nuget-token "${{secrets.NUGET_TOKEN != '' && secrets.NUGET_TOKEN || 'no_token'}}" --github-token "${{secrets.GITHUB_TOKEN}}" src/dotnet-releaser.toml
6 changes: 3 additions & 3 deletions doc/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ HelloWorld.1.0.0.win-x64.zip
The `publish` command allows to build and publish all packages to GitHub and NuGet.

```shell
dotnet-releaser publish --force --github-token ${{secrets.GITHUB_TOKEN}} --nuget-token YOUR_NUGET_TOKEN_HERE dotnet-releaser.toml
dotnet-releaser publish --force --github-token "${{secrets.GITHUB_TOKEN}}" --nuget-token "${{secrets.YOUR_NUGET_SECRET_TOKEN}}" dotnet-releaser.toml
```

> NOTE: When running from a GitHub Action, it is recommended to use the predefined `GITHUB_TOKEN` accessible from your secrets: `${{secrets.GITHUB_TOKEN}}`.
Expand Down Expand Up @@ -160,7 +160,7 @@ In order to use `dotnet-releaser` on your GitHub CI, you need:
```
4. To run the dotnet-releaser command assuming that you have added all the secret tokens to your GitHub repository
```sh
dotnet-releaser run --nuget-token ${{secrets.NUGET_TOKEN}} --github-token ${{secrets.GITHUB_TOKEN}} src/dotnet-releaser.toml
dotnet-releaser run --nuget-token "${{secrets.NUGET_TOKEN != '' && secrets.NUGET_TOKEN || 'no_token'}}" --github-token "${{secrets.GITHUB_TOKEN}}" src/dotnet-releaser.toml
```

Depending on the kind of GitHub event, the run command will automatically:
Expand Down Expand Up @@ -189,7 +189,7 @@ An example of a setup with GitHub Actions:
- name: Build, Tests, Cover, Pack and Publish (on push tag)
run: |
dotnet tool install --global dotnet-releaser
dotnet-releaser run --nuget-token ${{secrets.NUGET_TOKEN}} --github-token ${{secrets.GITHUB_TOKEN}} src/dotnet-releaser.toml
dotnet-releaser run --nuget-token "${{secrets.NUGET_TOKEN != '' && secrets.NUGET_TOKEN || 'no_token'}}" --github-token "${{secrets.GITHUB_TOKEN}}" src/dotnet-releaser.toml
```
> **NOTE about tokens:**
Expand Down
4 changes: 1 addition & 3 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,9 @@ By default, `dotnet-releaser` will:
- name: Build, Tests, Cover, Pack and Publish (on push tag)
run: |
dotnet tool install --global dotnet-releaser
dotnet-releaser run --nuget-token ${{secrets.NUGET_TOKEN}} --github-token ${{secrets.GITHUB_TOKEN}} src/dotnet-releaser.toml
dotnet-releaser run --nuget-token "${{secrets.NUGET_TOKEN != '' && secrets.NUGET_TOKEN || 'no_token'}}" --github-token "${{secrets.GITHUB_TOKEN}}" src/dotnet-releaser.toml
```
See the user guide below for further details on how to use `dotnet-releaser`.

## User Guide
Expand Down

0 comments on commit fd54457

Please sign in to comment.