Skip to content

Commit

Permalink
Fix test/ref text different and remove expectations.
Browse files Browse the repository at this point in the history
Remove the remaining test failures for writing-mode propagation to
viewport from TestExpectations. One of the tests had a missing period
in the test text that caused it to fail, and the other one was fixed in
the github repo, now passing.

Bug: 988585
Change-Id: I307eb4453479a71529f6c96d87b299f22a7a2c36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875263
Reviewed-by: Stephen Chenney <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#708748}
  • Loading branch information
lilles authored and Commit Bot committed Oct 23, 2019
1 parent 16d70be commit fea4a36
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions third_party/blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1973,11 +1973,6 @@ crbug.com/467635 fast/dom/HTMLImageElement/image-sizes-meta-viewport.html [ Skip
crbug.com/636239 [ Win7 ] media/video-zoom-controls.html [ Failure ]
crbug.com/636239 [ Win7 ] virtual/audio-service/media/video-zoom-controls.html [ Failure ]

# The spec for "Propagation to the Initial Containing Block" was changed.
# https://drafts.csswg.org/css-writing-modes-4/#icb
crbug.com/988585 external/wpt/css/css-writing-modes/wm-propagation-001.html [ Failure ]
crbug.com/988585 external/wpt/css/css-writing-modes/wm-propagation-body-044.html [ Failure ]

# Printing Layout broken in these tests.
crbug.com/377696 printing/setPrinting.html [ Skip ]
crbug.com/377696 printing/width-overflow.html [ Skip ]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
}
</style>
<script>
document.documentElement.append("This text must be vertical");
document.documentElement.append("This text must be vertical.");
/* This is direct content of the root,
and should therefore be vertical,
as the root's used value is vertical */
Expand Down

0 comments on commit fea4a36

Please sign in to comment.