Merge pull request apache#1030 from ma-xiao-guang-64/dev

fix batch insert bug
xuse · Jul 19, 2018 · 97d61af · 97d61af
2 parents 9be8632 + 93e70b2
commit 97d61af
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...ding-core/src/main/java/io/shardingsphere/core/optimizer/insert/InsertOptimizeEngine.java b/...ding-core/src/main/java/io/shardingsphere/core/optimizer/insert/InsertOptimizeEngine.java
@@ -63,11 +63,13 @@ public ShardingConditions optimize() {
         List<ShardingCondition> result = new ArrayList<>(andConditions.size());
         Iterator<Number> generatedKeys = null;
         int count = 0;
+        int parametersCount = 0;
         for (AndCondition each : andConditions) {
             InsertValue insertValue = insertValues.get(count);
             List<Object> currentParameters = new ArrayList<>(insertValue.getParametersCount() + 1);
-            currentParameters.addAll(parameters.subList(count * insertValue.getParametersCount(), (count + 1) * insertValue.getParametersCount()));
-
+            if (insertValue.getParametersCount() > 0) {
+                currentParameters.addAll(parameters.subList(parametersCount, parametersCount += insertValue.getParametersCount()));
+            }
             String logicTableName = insertStatement.getTables().getSingleTableName();
             Optional<Column> generateKeyColumn = shardingRule.getGenerateKeyColumn(logicTableName);
             InsertShardingCondition insertShardingCondition;