Lib: add submitEvent to Dom_html and update appropriate function sign…

…atures (ocsigen#1077)
xvw · Dec 15, 2020 · 961d389 · 961d389
1 parent 28b4c20
commit 961d389
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 4 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,6 @@
 # ??? (??) - ??
 ## Features/Changes
+* Lib: add submitEvent to Dom_html and update appropriate function signatures
 * Compiler: complete support for OCaml 4.12
 * Lib: expose API to attached and retrieve js errors to/from ocaml exceptions
 

diff --git a/lib/js_of_ocaml/dom_html.ml b/lib/js_of_ocaml/dom_html.ml
@@ -414,6 +414,13 @@ and touch =
     method pageY : int readonly_prop
   end
 
+and submitEvent =
+  object
+    inherit event
+
+    method submitter : element t optdef readonly_prop
+  end
+
 and dragEvent =
   object
     inherit mouseEvent
@@ -1011,7 +1018,7 @@ class type formElement =
 
     method reset : unit meth
 
-    method onsubmit : ('self t, event t) event_listener writeonly_prop
+    method onsubmit : ('self t, submitEvent t) event_listener writeonly_prop
   end
 
 class type optGroupElement =

diff --git a/lib/js_of_ocaml/dom_html.mli b/lib/js_of_ocaml/dom_html.mli
@@ -423,6 +423,13 @@ and touch =
     method pageY : int readonly_prop
   end
 
+and submitEvent =
+  object
+    inherit event
+
+    method submitter : element t optdef readonly_prop
+  end
+
 and dragEvent =
   object
     inherit mouseEvent
@@ -841,7 +848,7 @@ class type formElement =
 
     method reset : unit meth
 
-    method onsubmit : ('self t, event t) event_listener writeonly_prop
+    method onsubmit : ('self t, submitEvent t) event_listener writeonly_prop
   end
 
 class type optGroupElement =
@@ -2333,7 +2340,7 @@ module Event : sig
 
   val timeupdate : event t typ
 
-  val submit : event t typ
+  val submit : submitEvent t typ
 
   val scroll : event t typ
 

diff --git a/lib/lwt/lwt_js_events.mli b/lib/lwt/lwt_js_events.mli
@@ -326,7 +326,7 @@ val submit :
      ?use_capture:bool
   -> ?passive:bool
   -> #Dom_html.eventTarget Js.t
-  -> Dom_html.event Js.t Lwt.t
+  -> Dom_html.submitEvent Js.t Lwt.t
 
 val select :
      ?use_capture:bool