Apply stylesheets client-side in a safer manner.

xxbastekxx · Sep 19, 2012 · 7621afe · 7621afe
1 parent 5dba8a6
commit 7621afe
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/r2/r2/public/static/js/jquery.reddit.js b/r2/r2/public/static/js/jquery.reddit.js
@@ -667,8 +667,10 @@ $.apply_stylesheet = function(cssText) {
          * that has the old stylesheet, and delete it. Then we add a
          * <style> with the new one */
         $("head").children('*[title="' + sheet_title + '"]').remove();
-        $("head").append("<style type='text/css' media='screen' title='" + 
-                         sheet_title + "'>" + cssText + "</style>");
+        var stylesheet = $('<style type="text/css" media="screen"></style>')
+            .attr('title', sheet_title)
+            .text(cssText)
+            .appendTo('head')
   }
 
 };