replace values with consts

xyclos · Oct 28, 2022 · d4a1cb5 · d4a1cb5
1 parent cc92859
commit d4a1cb5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/src/CONST.js b/src/CONST.js
@@ -12,6 +12,7 @@ const CONST = {
     ANDROID_PACKAGE_NAME,
     ANIMATED_TRANSITION: 300,
     ANIMATED_TRANSITION_FROM_VALUE: 100,
+    ANIMATION_IN_TIMING: 100,
 
     API_ATTACHMENT_VALIDATIONS: {
         // Same as the PHP layer allows

diff --git a/src/components/Popover/popoverPropTypes.js b/src/components/Popover/popoverPropTypes.js
@@ -1,6 +1,7 @@
 import _ from 'underscore';
 import PropTypes from 'prop-types';
 import {propTypes as modalPropTypes, defaultProps as defaultModalProps} from '../Modal/modalPropTypes';
+import CONST from '../../CONST';
 
 const propTypes = {
     ...(_.omit(modalPropTypes, ['type', 'popoverAnchorPosition'])),
@@ -25,7 +26,7 @@ const defaultProps = {
 
     animationIn: 'fadeIn',
     animationOut: 'fadeOut',
-    animationInTiming: 300,
+    animationInTiming: CONST.ANIMATED_TRANSITION,
 
     // Anchor position is optional only because it is not relevant on mobile
     anchorPosition: {},

diff --git a/src/components/PopoverMenu/popoverMenuPropTypes.js b/src/components/PopoverMenu/popoverMenuPropTypes.js
@@ -1,4 +1,5 @@
 import PropTypes from 'prop-types';
+import CONST from '../../CONST';
 
 const propTypes = {
     /** Callback method fired when the user requests to close the modal */
@@ -57,7 +58,7 @@ const propTypes = {
 const defaultProps = {
     animationIn: 'fadeIn',
     animationOut: 'fadeOut',
-    animationInTiming: 300,
+    animationInTiming: CONST.ANIMATED_TRANSITION,
     headerText: undefined,
     disableAnimation: true,
 };

diff --git a/src/pages/home/report/ReportActionCompose.js b/src/pages/home/report/ReportActionCompose.js
@@ -589,7 +589,7 @@ class ReportActionCompose extends React.Component {
                                                 </Tooltip>
                                             </View>
                                             <PopoverMenu
-                                                animationInTiming={100}
+                                                animationInTiming={CONST.ANIMATION_IN_TIMING}
                                                 isVisible={this.state.isMenuVisible}
                                                 onClose={() => this.setMenuVisibility(false)}
                                                 onItemSelected={() => this.setMenuVisibility(false)}