Merge pull request ccxt#8026 from dhensen/augur-currencies-confusion

Assumption: REP always means REPv2 and then there is REPV1. Binance t…

examples/py/async-analyse-augur-v1-vs-v2-exchanges.py

@@ -0,0 +1,88 @@
+# -*- coding: utf-8 -*-
+
+import asyncio
+import os
+import sys
+from typing import Optional
+
+root = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+sys.path.append(root + '/python')
+
+import ccxt.async_support as ccxt
+
+
+unchecked_exchanges = []
+
+
+def is_symbol_match(
+    symbol: str,
+    allowed_infix: str,
+    disallowed_infix: Optional[str] = None
+) -> bool:
+    """This function is to keep everything that has allowed_infix=REP, but
+    excpude everything that has disallowed_infix=DREP, except for when you encounter something like: REPV2/DREP
+
+    Returns True if this symbol is allowed to be in the list.
+
+    Args:
+        symbol (str): the symbol to evaluate
+        allowed_infix (str): the allowed infix for both currencies in this symbol
+        disallowed_infix (Optional[str], optional): the disallowed infix for when the other currency is does not have the allowed infix. Defaults to None.
+
+    Returns:
+        bool:
+    """
+    parts = symbol.split('/')
+
+    if disallowed_infix:
+        for i, currency in enumerate(parts):
+            if disallowed_infix in currency:
+                # if one currency contains for instance disallowed_infix=DREP,
+                # then the other currency must contain allowed_infix=REP to be allowed, else disallow
+                return allowed_infix in parts[i + 1 % 2]
+
+    return any([allowed_infix in currency for currency in parts])
+
+
+async def check_symbol_infix(exchange, symbol_infix, exclude_infix=None):
+    try:
+        await exchange.load_markets()
+    except Exception as exc:
+        # exchange could not load_markets for some reason...
+        unchecked_exchanges.append(exchange.id)
+    else:
+        matching_symbols = [
+            symbol for symbol in exchange.symbols
+            if is_symbol_match(symbol, symbol_infix, exclude_infix)
+        ]
+        if matching_symbols:
+            print(
+                f'on exchange {exchange.id} these symbols contain {symbol_infix}:'
+            )
+            for symbol in matching_symbols:
+                print(f' - {symbol}:')
+                # print(f'   exchange specific market info: {exchange.markets[symbol]["info"]}')
+                if 'V1' in symbol:
+                    print('   - marked V1')
+                if 'V2' in symbol:
+                    print('   - marked V2')
+            print()
+
+    await exchange.close()
+
+
+async def main():
+    tasks = []
+    for exchange_id in ccxt.exchanges:
+        exchange = getattr(ccxt, exchange_id)()
+        tasks.append(
+            check_symbol_infix(
+                exchange, symbol_infix='REP', exclude_infix='DREP'
+            )
+        )
+    await asyncio.gather(*tasks)
+
+    print(f'errors for exchanges: {", ".join(unchecked_exchanges)}')
+
+
+asyncio.run(main())

js/kraken.js

@@ -207,6 +207,8 @@ module.exports = class kraken extends Exchange {
             'commonCurrencies': {
                 'XBT': 'BTC',
                 'XDG': 'DOGE',
+                'REPV2': 'REP',
+                'REP': 'REPV1',
             },
             'options': {
                 'cacheDepositMethodsOnFetchDepositAddress': true, // will issue up to two calls in fetchDepositAddress