Skip to content

Commit

Permalink
Bug#28541029 PKGVER FAILED FOR WINDOWS X86-64BIT MSI PACKAGES - BOTH …
Browse files Browse the repository at this point in the history
…COMMUNITY AND COMMERCIAL

Problem:
Server 5.7 and 5.6 crash on msi uninstall due to missing dll reference. Wix 3.8 is used for building both server 5.6 and 5.7 msi when the packaging script has a reference to a custom action dll entry (WixQuietExec) only available in Wix 3.10 (and newer).

Fix:
Replaced WixQuietExec with CAQuietExec (available in wix 3.8 custom action dll).

(cherry picked from commit 57e71f991e9b59a6ca8ee0c6152e69982a935bf3)
  • Loading branch information
Piotr Obrzut authored and surbhat1595 committed Sep 10, 2018
1 parent 65ffeb9 commit 4789962
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packaging/WiX/mysql_server.wxs.in
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
</InstallUISequence>

<Property Id="QtRemoveService" Value="&quot;cmd.exe&quot; /S /V:ON /C &quot;echo off &amp; for /F &quot;tokens=*&quot; %i in ('sc query ^| FIND &quot;SERVICE_NAME:&quot;') do (set j=%i &amp; set j=!j:~14! &amp; sc qc !j! | FIND &quot;C:\Program Files\MySQL\MySQL Server 5.6\bin\&quot; >NUL &amp; IF errorlevel 0 IF NOT errorlevel 1 (sc stop !j! > NUL &amp; ( for /L %k IN (1,1,20) do (sc query !j! | FIND &quot;STATE&quot; | FIND &quot;STOPPED&quot; >NUL &amp; (IF errorlevel 0 IF errorlevel 1 timeout /t 5 /nobreak >NUL)) )&amp; sc delete !j! ) ) &quot;"/>
<CustomAction Id="QtRemoveService" BinaryKey="WixCA" DllEntry="WixQuietExec"
<CustomAction Id="QtRemoveService" BinaryKey="WixCA" DllEntry="CAQuietExec"
Execute="deferred" Return="check" Impersonate="no"/>
<InstallExecuteSequence>
<Custom Action="QtRemoveService" After="InstallInitialize">(NOT UPGRADINGPRODUCTCODE) AND (REMOVE="ALL") AND (NOT MYSQL_INSTALLER="YES")</Custom>
Expand Down

0 comments on commit 4789962

Please sign in to comment.