Skip to content

Commit

Permalink
fix fieldstats
Browse files Browse the repository at this point in the history
  • Loading branch information
ofir76 committed Apr 11, 2018
1 parent e3af9b9 commit 8b40bd5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
8 changes: 3 additions & 5 deletions jest-common/src/main/java/io/searchbox/fields/FieldStats.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

import io.searchbox.action.AbstractAction;
import io.searchbox.action.GenericResultAbstractAction;
import io.searchbox.client.config.ElasticsearchVersion;
import io.searchbox.params.Parameters;

import java.util.HashMap;
import java.util.Map;

public class FieldStats extends GenericResultAbstractAction {

protected FieldStats(FieldStats.Builder builder) {
super(builder);

Expand All @@ -18,8 +18,6 @@ protected FieldStats(FieldStats.Builder builder) {
fieldStatsBody.put("fields", builder.fields);

this.payload = fieldStatsBody;

setURI(buildURI());
}

@Override
Expand All @@ -28,8 +26,8 @@ public String getRestMethodName() {
}

@Override
protected String buildURI() {
String buildURI = super.buildURI();
protected String buildURI(ElasticsearchVersion elasticsearchVersion) {
String buildURI = super.buildURI(elasticsearchVersion);
if (buildURI.isEmpty())
return "_field_stats";

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.searchbox.fields;

import com.google.gson.Gson;
import io.searchbox.client.config.ElasticsearchVersion;
import org.junit.Test;

import java.util.Collections;
Expand All @@ -17,23 +18,23 @@ public class FieldsStatsTest {
public void testBasicUriGeneration() {
FieldStats fieldStats = new FieldStats.Builder(FIELDS).setIndex(INDEX).build();
assertEquals("POST", fieldStats.getRestMethodName());
assertEquals(INDEX + "/_field_stats", fieldStats.getURI());
assertEquals(INDEX + "/_field_stats", fieldStats.getURI(ElasticsearchVersion.V55));
assertEquals("{\"fields\":[\"" + TEST_FIELD + "\"]}", fieldStats.getData(new Gson()));
}

@Test
public void testBasicUriGenerationNoIndex() {
FieldStats fieldStats = new FieldStats.Builder(FIELDS).build();
assertEquals("POST", fieldStats.getRestMethodName());
assertEquals("_field_stats", fieldStats.getURI());
assertEquals("_field_stats", fieldStats.getURI(ElasticsearchVersion.V55));
assertEquals("{\"fields\":[\"" + TEST_FIELD + "\"]}", fieldStats.getData(new Gson()));
}

@Test
public void testBasicUriGenerationWithLevel() {
FieldStats fieldStats = new FieldStats.Builder(FIELDS).setIndex(INDEX).setLevel("indices").build();
assertEquals("POST", fieldStats.getRestMethodName());
assertEquals(INDEX + "/_field_stats?level=indices", fieldStats.getURI());
assertEquals(INDEX + "/_field_stats?level=indices", fieldStats.getURI(ElasticsearchVersion.V55));
assertEquals("{\"fields\":[\"" + TEST_FIELD + "\"]}", fieldStats.getData(new Gson()));
}
}

0 comments on commit 8b40bd5

Please sign in to comment.