scollectd: change get_collectd_value() to use const ref

After the implementation of the code that uses the scollectd API was modified, the get_collectd_value gets the collectd ID as a const reference, to remove unnessary creation of shared_ptr. Signed-off-by: Amnon Heiman <[email protected]>
yangxingpping · Jul 6, 2015 · 2c08647 · 2c08647
1 parent a4a23f8
commit 2c08647
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/scollectd.cc b/core/scollectd.cc
@@ -488,9 +488,9 @@ boost::program_options::options_description get_options_description() {
 }
 
 std::vector<collectd_value> get_collectd_value(
-        shared_ptr<scollectd::type_instance_id> id) {
+        const scollectd::type_instance_id& id) {
     std::vector<collectd_value> res_values;
-    auto raw_types = get_impl().get_values(*id);
+    auto raw_types = get_impl().get_values(id);
     if (raw_types == nullptr) {
         return res_values;
     }

diff --git a/core/scollectd_api.hh b/core/scollectd_api.hh
@@ -49,7 +49,7 @@ struct collectd_value {
 };
 
 std::vector<collectd_value> get_collectd_value(
-        shared_ptr<scollectd::type_instance_id> id);
+        const scollectd::type_instance_id& id);
 
 std::vector<scollectd::type_instance_id> get_collectd_ids();