crypto: fix error condition in Verify::VerifyFinal

Fail early if key parsing failed, don't try to construct a context out of it. PR-URL: nodejs#26238 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
yannh · Feb 23, 2019 · 10c3db3 · 10c3db3
1 parent 8ebd339
commit 10c3db3
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -4675,6 +4675,8 @@ void Verify::VerifyFinal(const FunctionCallbackInfo<Value>& args) {
 
   unsigned int offset = 0;
   ManagedEVPPKey pkey = GetPublicOrPrivateKeyFromJs(args, &offset, true);
+  if (!pkey)
+    return;
 
   char* hbuf = Buffer::Data(args[offset]);
   ssize_t hlen = Buffer::Length(args[offset]);