src: use smart pointer in UDPWrap::OnSend

PR-URL: nodejs#26233 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
yannh · Feb 25, 2019 · 47c7842 · 47c7842
1 parent 84e02b1
commit 47c7842
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/udp_wrap.cc b/src/udp_wrap.cc
@@ -444,7 +444,7 @@ void UDPWrap::RecvStop(const FunctionCallbackInfo<Value>& args) {
 
 
 void UDPWrap::OnSend(uv_udp_send_t* req, int status) {
-  SendWrap* req_wrap = static_cast<SendWrap*>(req->data);
+  std::unique_ptr<SendWrap> req_wrap{static_cast<SendWrap*>(req->data)};
   if (req_wrap->have_callback()) {
     Environment* env = req_wrap->env();
     HandleScope handle_scope(env->isolate());
@@ -455,7 +455,6 @@ void UDPWrap::OnSend(uv_udp_send_t* req, int status) {
     };
     req_wrap->MakeCallback(env->oncomplete_string(), 2, arg);
   }
-  delete req_wrap;
 }