http: validate timeout in ClientRequest()

Validate the timeout option in the ClientRequest() constructor to prevent asynchronously thrown validation errors. PR-URL: nodejs#26214 Fixes: nodejs#26143 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
yannh · Feb 26, 2019 · 907941d · 907941d
1 parent 4900863
commit 907941d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -140,7 +140,9 @@ function ClientRequest(input, options, cb) {
   var setHost = (options.setHost === undefined || Boolean(options.setHost));
 
   this.socketPath = options.socketPath;
-  this.timeout = options.timeout;
+
+  if (options.timeout !== undefined)
+    this.timeout = validateTimerDuration(options.timeout, 'timeout');
 
   var method = options.method;
   var methodIsString = (typeof method === 'string');

diff --git a/test/parallel/test-http-client-timeout-option.js b/test/parallel/test-http-client-timeout-option.js
@@ -3,6 +3,10 @@ const common = require('../common');
 const assert = require('assert');
 const http = require('http');
 
+assert.throws(() => {
+  http.request({ timeout: null });
+}, /The "timeout" argument must be of type number/);
+
 const options = {
   method: 'GET',
   port: undefined,