Feature implementation from commits a4310a8..0c2afc9 #2

yashuatla · 2025-06-24T17:07:03Z

This PR contains changes from a range of commits from the original repository.

Commit Range: a4310a8..0c2afc9
Files Changed: 72 (30 programming files)
Programming Ratio: 41.7%

Commits included:

Updated readme with new section about createReducer API
Updated readme
Added doctoc
Added prettier to common npm scripts
Capitalize file to fix import on POSIX systems (Capitalize file to fix import on POSIX systems piotrwitek/react-redux-typescript-guide#160)
Refactored playground to use create-react-app (Refactored playground to use create-react-app piotrwitek/react-redux-typescript-guide#159)
Added ESLint config section (Added ESLint config section piotrwitek/react-redux-typescript-guide#158)
Added new solution to Connect with react-redux to solve validation of action creators with bindActionCreators (Validation of action creators with bindActionCreators piotrwitek/react-redux-typescript-guide#157)
Updated playground project and added integration with react-redux-typescript-scripts (Added integration with react-redux-typescript-scripts piotrwitek/react-redux-typescript-guide#156)
Small updates
... and 15 more commits

FIxes piotrwitek#63 - Related to piotrwitek#130

* Update dependencies and react types and simplified use reducer example * Updated playground code to be up to date with updated librariesFixed piotrwitek#138 * Updated readme * Updated contributors

Fixes piotrwitek#140 Let me know if it looks good or I need to make any changes. Thanks!

* Added reference example for testing of epics * updated hoc typings

usefull -> useful

…iotrwitek#119

…escript-scripts (piotrwitek#156) Resolved piotrwitek#69

…of action creators with bindActionCreators (piotrwitek#157)

Resolved piotrwitek#151

On my Linux system, the playground example did not compile right away, because `Home` was imported, but the file was called `home.tsx`.

codeowlai · 2025-06-24T17:09:12Z

playground/src/features/counters/index.ts

@@ -1,13 +1,11 @@
 import * as countersConstants from './constants';
 import * as countersActions from './actions';
-import countersReducer, { CountersState, CountersAction } from './reducer';
+import countersReducer from './reducer';


🐛 Correctness Issue

Removed type exports may break dependent code.

Removing CountersState and CountersAction exports could cause compilation errors in any code that imports these types from this barrel file.

Current Code (Diff):

- import countersReducer from './reducer'; + import countersReducer, { CountersState, CountersAction } from './reducer';

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

import countersReducer from './reducer';

import countersReducer, { CountersState, CountersAction } from './reducer';

codeowlai · 2025-06-24T17:09:16Z

playground/src/features/todos-typesafe/index.ts

 import * as todosSelectors from './selectors';
-export { todosActions, todosSelectors, todosReducer, TodosState, TodosAction };
+export { todosActions, todosSelectors, todosReducer };


🐛 Correctness Issue

Breaking API Change: Removed Type Exports.

Removing TodosState and TodosAction types from public exports will break any code that imports these types from this module.

Current Code (Diff):

- export { todosActions, todosSelectors, todosReducer }; + export { todosActions, todosSelectors, todosReducer, TodosState, TodosAction };

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

export { todosActions, todosSelectors, todosReducer };

export { todosActions, todosSelectors, todosReducer, TodosState, TodosAction };

codeowlai · 2025-06-24T17:09:20Z

playground/src/features/todos-typesafe/index.ts

@@ -1,5 +1,5 @@
 // public API
 import * as todosActions from './actions';
-import todosReducer, { TodosState, TodosAction } from './reducer';
+import todosReducer from './reducer';


🐛 Correctness Issue

Missing Type Imports for Public API.

The TodosState and TodosAction types need to be imported if they are to be exported in the public API.

Current Code (Diff):

- import todosReducer from './reducer'; + import todosReducer, { TodosState, TodosAction } from './reducer';

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

import todosReducer from './reducer';

import todosReducer, { TodosState, TodosAction } from './reducer';

codeowlai · 2025-06-24T17:09:24Z

playground/src/features/todos/epics.ts

@@ -20,5 +20,3 @@ const logAddAction: Epic<TodosAction, Types.RootState, Types.Services> = (
    }),
    ignoreElements()
  );


🐛 Correctness Issue

Critical Export Removed.

The export statement for the logAddAction epic has been removed, which will break any code that imports this epic and cause runtime errors in the Redux middleware.

Current Code (Diff):

+ export default combineEpics(logAddAction);

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

);

export default combineEpics(logAddAction);

codeowlai · 2025-06-24T17:09:28Z

playground/src/features/todos/index.ts

@@ -1,13 +1,6 @@
 // public API
 import * as todosConstants from './constants';
 import * as todosActions from './actions';
-import todosReducer, { TodosState, TodosAction } from './reducer';
+import todosReducer from './reducer';


🐛 Correctness Issue

Breaking API Change: Removed Type Exports.

Removing TodosState and TodosAction types from the public API will break any code that imports these types from this module.

Current Code (Diff):

- import todosReducer from './reducer'; + import todosReducer, { TodosState, TodosAction } from './reducer';

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

import todosReducer from './reducer';

import todosReducer, { TodosState, TodosAction } from './reducer';

codeowlai · 2025-06-24T17:09:32Z

playground/src/features/todos/index.ts

-  TodosState,
-  TodosAction,
-};
+export { todosConstants, todosActions, todosSelectors, todosReducer };


🐛 Correctness Issue

Breaking API Change: Removed Type Exports.

Removing TodosState and TodosAction types from the exports will break any code that imports these types from this module.

Current Code (Diff):

- export { todosConstants, todosActions, todosSelectors, todosReducer }; + export { todosConstants, todosActions, todosSelectors, todosReducer, TodosState, TodosAction };

📝 Committable suggestion

‼️ IMPORTANT
Trust, but verify! 🕵️ Please review this suggestion with the care of a code archaeologist - check that it perfectly replaces the highlighted code, preserves all lines, maintains proper indentation, and won't break anything in production. Your future self will thank you! 🚀

Suggested change

export { todosConstants, todosActions, todosSelectors, todosReducer };

export { todosConstants, todosActions, todosSelectors, todosReducer, TodosState, TodosAction };

piotrwitek and others added 25 commits February 3, 2019 19:18

Updated tests to fix build Closed piotrwitek#95 (piotrwitek#133)

bdec1e5

Adds info import module decleration (piotrwitek#134)

857d9fd

FIxes piotrwitek#63 - Related to piotrwitek#130

Updated Recipes section Closed piotrwitek#137

23ffca5

Updated TOC

8f51601

Updated deps (piotrwitek#139)

af7d940

* Update dependencies and react types and simplified use reducer example * Updated playground code to be up to date with updated librariesFixed piotrwitek#138 * Updated readme * Updated contributors

Added example for using context in class component (piotrwitek#141)

c06d37a

Fixes piotrwitek#140 Let me know if it looks good or I need to make any changes. Thanks!

Testing epics (piotrwitek#144)

33d96b6

* Added reference example for testing of epics * updated hoc typings

updated deps

8c796de

added redux-thunk types overload

1259b21

Updated legacy patterns

d0a05b2

ThunkActionType prototype

5d03b97

fix spelling mistake (piotrwitek#152)

342a6ad

usefull -> useful

Updated docs and and example of integration with redux-thunk Resolved p…

0ecf245

…iotrwitek#119

Merge branch 'redux-thunk'

c8d35fe

Added hyperlinks for better UX

b5cefb4

Small updates

34fc808

Updated playground project and added integration with react-redux-typ…

e732b43

…escript-scripts (piotrwitek#156) Resolved piotrwitek#69

Added new solution to Connect with react-redux to solve validation …

3f978be

…of action creators with bindActionCreators (piotrwitek#157)

Added ESLint config section (piotrwitek#158)

acd9b20

Refactored playground to use create-react-app (piotrwitek#159)

93fc2b8

Resolved piotrwitek#151

Capitalize file to fix import on POSIX systems (piotrwitek#160)

cf8a03c

On my Linux system, the playground example did not compile right away, because `Home` was imported, but the file was called `home.tsx`.

Added prettier to common npm scripts

05ddc8f

Added doctoc

0ff885d

Updated readme

01bc1df

Updated readme with new section about createReducer API

0c2afc9

codeowlai bot reviewed Jun 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature implementation from commits a4310a8..0c2afc9 #2

Feature implementation from commits a4310a8..0c2afc9 #2

Uh oh!

yashuatla commented Jun 24, 2025

Uh oh!

codeowlai bot Jun 24, 2025

Uh oh!

codeowlai bot Jun 24, 2025

Uh oh!

codeowlai bot Jun 24, 2025

Uh oh!

codeowlai bot Jun 24, 2025

Uh oh!

codeowlai bot Jun 24, 2025

Uh oh!

codeowlai bot Jun 24, 2025

Uh oh!

Uh oh!

	import countersReducer from './reducer';
	import countersReducer, { CountersState, CountersAction } from './reducer';

	export { todosActions, todosSelectors, todosReducer };
	export { todosActions, todosSelectors, todosReducer, TodosState, TodosAction };

	import todosReducer from './reducer';
	import todosReducer, { TodosState, TodosAction } from './reducer';

	export { todosConstants, todosActions, todosSelectors, todosReducer };
	export { todosConstants, todosActions, todosSelectors, todosReducer, TodosState, TodosAction };

Feature implementation from commits a4310a8..0c2afc9 #2

Are you sure you want to change the base?

Feature implementation from commits a4310a8..0c2afc9 #2

Uh oh!

Conversation

yashuatla commented Jun 24, 2025

Uh oh!

codeowlai bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeowlai bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!