feat: display view query text #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
force-pushed
the
astandrik.view-query-text-on-info-919-2
branch
from
d05b88c to
14ca9f9
Compare
There was a problem hiding this comment.
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (3)
- package.json: Language not supported
- src/components/YqlHighlighter/YqlHighlighter.scss: Language not supported
- playwright.config.ts: Evaluated as low risk
Raubzeug
requested changes
Dec 23, 2024
| @@ -36,8 +37,11 @@ interface OneLineQueryWithPopoverProps { | |||
|
|
|||
| export const OneLineQueryWithPopover = ({value = ''}: OneLineQueryWithPopoverProps) => { | |||
| return ( | |||
| <CellWithPopover contentClassName={b('popover-content')} content={value}> | |||
| {value} | |||
| <CellWithPopover | |||
There was a problem hiding this comment.
Do we really need a popover here?
There was a problem hiding this comment.
removed popover
redeployed stand
Raubzeug
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1755
Closes #919
Stand
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 66.16 MB | Main: 65.89 MB
Diff: +0.27 MB (0.41%)
ℹ️ CI Information