feat(autocomplete): suggest columns from subqueries #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
force-pushed
the
autocomplete
branch
from
b875e85 to
fd06b37
Compare
| let columnsFromVariable: TAutocompleteEntity[] = []; | ||
| if (variableSources.length) { | ||
| variableSources.forEach((source) => { | ||
| columnsFromVariable = |
There was a problem hiding this comment.
Reassigning columnsFromVariable inside the loop could lead to unexpected results. It should accumulate results instead. Change to columnsFromVariable.push(...).
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
astandrik
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #898
closes #903
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 66.17 MB | Main: 66.16 MB
Diff: +8.91 KB (0.01%)
ℹ️ CI Information