Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes in detector goroutines leak #1674

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Small changes in detector goroutines leak #1674

merged 1 commit into from
Mar 7, 2025

Conversation

asmyasnikov
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.07%. Comparing base (121aceb) to head (ef5c063).

Files with missing lines Patch % Lines
internal/xtest/leak.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
- Coverage   71.21%   68.07%   -3.15%     
==========================================
  Files         380      380              
  Lines       39165    39164       -1     
==========================================
- Hits        27893    26660    -1233     
- Misses      10128    11329    +1201     
- Partials     1144     1175      +31     
Flag Coverage Δ
experiment ?
go-1.21.x 70.50% <50.00%> (-0.20%) ⬇️
go-1.24.x 68.06% <50.00%> (-3.14%) ⬇️
integration 52.16% <33.33%> (-0.61%) ⬇️
macOS 37.72% <50.00%> (-0.02%) ⬇️
ubuntu 68.07% <50.00%> (-3.15%) ⬇️
unit 37.72% <50.00%> (-0.03%) ⬇️
windows 37.70% <50.00%> (-0.03%) ⬇️
ydb-24.1 52.09% <33.33%> (-0.56%) ⬇️
ydb-24.2 51.94% <33.33%> (-0.77%) ⬇️
ydb-24.3 52.13% <33.33%> (-0.56%) ⬇️
ydb-nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 6, 2025

summary

Base version: v3.100.4-0.20250304221314-121aceb102e7 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.100.3.

@asmyasnikov asmyasnikov merged commit feae7e6 into master Mar 7, 2025
34 of 35 checks passed
@asmyasnikov asmyasnikov deleted the goleak branch March 7, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants