This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Global: making collect audio plugin global #3679
Merged
+130
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubjezek001
added
the
type: feature
iLLiCiTiT
reviewed
Aug 16, 2022
BigRoy
reviewed
Aug 17, 2022
iLLiCiTiT
reviewed
Aug 17, 2022
BigRoy
reviewed
Aug 18, 2022
|
Already removed OcioConfig submodule is added back to repository. |
iLLiCiTiT
reviewed
Aug 24, 2022
iLLiCiTiT
reviewed
Aug 24, 2022
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
iLLiCiTiT
reviewed
Aug 24, 2022
| @@ -3,6 +3,10 @@ | |||
| "CollectAnatomyInstanceData": { | |||
| "follow_workfile_version": false | |||
| }, | |||
| "CollectAudio": { | |||
| "enabled": true, | |||
There was a problem hiding this comment.
I would turn this plugin off by default as most of studios don't use audio and current state of plugin could do a lot of queries to mongo.
|
I tested on EXR sequence, available audio was added to the reviewable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Collect audio plugin could be used by other hosts.
Description
Reviewable videos can be created with included audio tracks if any audio subset is available. Subset name with audio variant can be defined in settings
project_settings/global/publish/CollectAudio/audio_subset_nameTesting notes: