Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Playblast profiles #4777

Merged
merged 36 commits into from
Apr 14, 2023
Merged

Maya: Playblast profiles #4777

merged 36 commits into from
Apr 14, 2023
+921 −54

Conversation

tokejepsen
Copy link
Member

Changelog Description

Support playblast profiles.

This enables studios to customize what playblast settings should be on a per task and/or subset basis. For example modeling should have Wireframe On Shaded enabled, while all other tasks should have it disabled.

Additional info

Currently this a breaking change because of changing the settings from a single set of playblast settings to multiple. Let's discuss the smoothest way to transition.

Testing notes:

  1. Create 2 tasks of type modeling and animation.
  2. Create a new profile under project_settings/maya/publish/ExtractPlayblast/profiles with modeling as task type. Modify the modeling profile to be different from the default profile. Suggestion is to enable Wireframe On Shaded (project_settings/maya/publish/ExtractPlayblast/profiles/0/capture_preset/Viewport Options/wireframeOnShaded).
  3. Launch Maya and publish a review from both the modeling and animation task.
  4. Validate the reviews are as the defined settings.

@tokejepsen
Setup settings.
32743b7
@tokejepsen
Default values for profiles.
87dc14f
@tokejepsen
create review for profiles
655ae7e
@tokejepsen
Move review camera validation to validator.
7444e33
@tokejepsen
Support review profiles in extraction
c4b8875
@tokejepsen
Merge branch 'develop' into enhancement/OP-3807_playblast_profiles
d2be161 
# Conflicts:
#	openpype/hosts/maya/plugins/publish/collect_review.py
#	openpype/settings/defaults/project_settings/maya.json
#	openpype/settings/entities/schemas/projects_schema/schemas/schema_maya_capture.json
@tokejepsen
Order display options better.
b960b65
@ynbot
Copy link
Contributor

ynbot commented Apr 5, 2023

Task linked: OP-3807 Playblast options per task/family/subset

@tokejepsen
Copy link
Member Author

@iLLiCiTiT would like your input on how to best to tackle the transition.

LiborBatek
LiborBatek previously approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did follow the testing steps and created 2 types of Review Instance one for model instance and other for animation instance.

They were correctly created with predefined settings in OP (model with wireframes on shaded, animation with defaults)

BigRoy
BigRoy reviewed Apr 5, 2023
View reviewed changes
openpype/hosts/maya/plugins/create/create_review.py Outdated Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/validate_review.py Outdated Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/extract_thumbnail.py Show resolved Hide resolved
openpype/hosts/maya/plugins/publish/extract_thumbnail.py Outdated Show resolved Hide resolved
openpype/settings/defaults/project_settings/maya.json Outdated Show resolved Hide resolved
openpype/settings/entities/input_entities.py Show resolved Hide resolved
openpype/settings/entities/color_entity.py Show resolved Hide resolved
openpype/settings/entities/schemas/projects_schema/schemas/schema_maya_capture.json Outdated Show resolved Hide resolved
openpype/settings/entities/schemas/projects_schema/schemas/schema_maya_capture.json Outdated Show resolved Hide resolved
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Apr 5, 2023 •
edited
Loading

@iLLiCiTiT would like your input on how to best to tackle the transition.

I think we have to expect that profiles are not available yet. Also I would keep capture_preset for some time, so studios won't loose previous values and can move them to profiles.

You can mark capture_preset with label marking it as deprecated and point it to profiles, keep the schema there so they can access the values.

@tokejepsen tokejepsen assigned tokejepsen and unassigned LiborBatek Apr 5, 2023
@ynbot ynbot added type: enhancement Enhancements to existing functionality host: Maya labels Apr 5, 2023
@tokejepsen
Copy link
Member Author

@BigRoy @iLLiCiTiT hows this PR looking now?

@tokejepsen tokejepsen assigned LiborBatek and unassigned iLLiCiTiT Apr 13, 2023
@iLLiCiTiT
Copy link
Member

Note: With profiles there is option that any capture preset is used. Now is used "default" from deprecated settings, but when those are removed it could crash on many places.

iLLiCiTiT
iLLiCiTiT approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkolar mkolar changed the title Maya: Playblast profiles - OP-3807 Maya: Playblast profiles Apr 14, 2023
@tokejepsen
Copy link
Member Author

@LiborBatek would you mind giving this a run through again?

@BigRoy you happy with this PR?

@tokejepsen
Merge branch 'develop' into enhancement/OP-3807_playblast_profiles
281f618 
# Conflicts:
#	openpype/hosts/maya/plugins/create/create_review.py
BigRoy
BigRoy approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do a test run of the code, but this looks good to me!

@LiborBatek LiborBatek self-requested a review April 14, 2023 14:48
LiborBatek
LiborBatek approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working fine. Did create new profile with different settings for model family and compare it to the default profile for the rest of families. All as expected

image

image

@BigRoy
Copy link
Collaborator

BigRoy commented Apr 14, 2023

I'm almost sure that the next feature request will be - how can I generate two playblasts from modeling? On with wireframe and one with smooth shading, etc. haha.

Anyway, solid work!

@tokejepsen
Copy link
Member Author

I'm almost sure that the next feature request will be - how can I generate two playblasts from modeling? On with wireframe and one with smooth shading, etc. haha.

Lol, yeah. Probably not a huge amount of work, as you could have two profiles targetting modeling but thats famous last words.

@tokejepsen tokejepsen assigned antirotor and unassigned LiborBatek Apr 14, 2023
@antirotor antirotor merged commit dc82268 into ynput:develop Apr 14, 2023
@ynbot ynbot added this to the next-patch milestone Apr 14, 2023
@tokejepsen tokejepsen deleted the enhancement/OP-3807_playblast_profiles branch April 14, 2023 16:23
@tokejepsen tokejepsen mentioned this pull request May 11, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar left review comments

@LiborBatek LiborBatek LiborBatek approved these changes

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@antirotor antirotor antirotor approved these changes

@BigRoy BigRoy BigRoy approved these changes

Assignees

@antirotor antirotor

Labels
host: Maya type: enhancement Enhancements to existing functionality
Projects
PR reviewing
Archived in project
Milestone
3.15.5
Development

Successfully merging this pull request may close these issues.
7 participants
@tokejepsen @ynbot @iLLiCiTiT @BigRoy @mkolar @antirotor @LiborBatek