re-enable strict typing in two files #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a recent upgrade to sorbet (#546) I found that I was able to re-enable strict typing here. It was disabled in #513 because sorbet wasn't finding the type annotation in the rbi file for some constants. It's still inconsisent (for example, I wasn't able to change the cmap.rb back to strict), but these ones are OK.
yob
commented
Jan 13, 2025
| @@ -52,7 +52,7 @@ class Buffer | |||
| CR = "\r" | |||
| LF = "\n" | |||
| CRLF = "\r\n" | |||
| WHITE_SPACE = [LF, CR, ' '] | |||
| WHITE_SPACE = ["\n", "\r", ' '] | |||
There was a problem hiding this comment.
sorbet ignored the type definition in the rbi file until I changed this to use literals and not reference the earlier constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a recent upgrade to sorbet (#546) I found that I was able to re-enable strict typing here.
It was disabled in #513 because sorbet wasn't finding the type annotation in the rbi file for some constants. It's still inconsistent (for example, I wasn't able to change the cmap.rb back to strict), but these ones are OK.
The constants where sorbet ignores the type definition in the rbi file are all Hashes 🤔