[draft] Yophilav/test azure pipelines #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DpsX509 when run alone, as it previously relied on a previous test to generate certs.
This PR is a copy of Azure#5630. Even Though this PR is a cherry-pick , Some later merges require it to be treated as a non-cherry-pick. Will Add E2E Test Results here # Azure IoT Edge PR checklist: E2E Test Result here : https://dev.azure.com/msazure/One/_build/results?buildId=47704973&view=results This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
Fixes Azure#5514 Remove and recreate the edgeAgent module when its state is not Running, Stopped, or Failed.
Azure#5702) For ISA95 Smoke Tests, removing the commit trigger in favor of scheduled builds. Will port this change to master also. Waiting for this run before merge: https://dev.azure.com/msazure/One/_build/results?buildId=47888354&view=results # Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes. - Description of the pull request includes - [ ] concise summary of tests added/modified - [ ] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
Fix for Azure#5672, Azure#5505 , Azure#5693 Restarting iotedge many time lead to the following permission issues:  This doesn't seem to happen in 1.1.6. I tried many times but could not get it to fail however some customer experienced the same symptoms so this is most likely an issue across version. The fact that it seems to fail more on some setup is something we could not explain. Tests: 1. Tried all of those. A few times manually (3-5 times), a cycle of hundreds time each with a script (Ubuntu + Centos). For each test we check that all module are up and running, that permissions and user are correct and that there is a listener on the socket: 1.1 sudo iotedge system restart 1.2 sudo iotedge system stop + delete all containers + sudo iotedge system restart 1.3 sudo iotedge system stop + delete /var/lib/aziot/edged/mnt/ folder + sudo iotedge system restart 1.4 sudo iotedge system stop + delete all container + delete /var/lib/aziot/edged/mnt/ folder + sudo iotedge system restart 1.5 sudo iotedge system stop + delete workloads inside /var/lib/aziot/edged/mnt + create a sudo dir inside with the name of the sockets + sudo iotedge system restart Logs [ubuntu18.txt](https://github.com/Azure/iotedge/files/7358293/ubuntu18.txt) [centos.txt](https://github.com/Azure/iotedge/files/7358294/centos.txt) scripts code: ``` while : do echo "Test 1" sudo iotedge system restart sleep 310s sudo iotedge list ls -l /var/lib/aziot/edged/mnt/ curl curl --unix-socket /var/lib/aziot/edged/mnt/SimulatedTemperatureSensor.sock http://127.0.0.1 curl curl --unix-socket /var/lib/aziot/edged/mnt/edgeAgent.sock http://127.0.0.1 curl curl --unix-socket /var/lib/aziot/edged/mnt/edgeHub.sock http://127.0.0.1 echo "Test 2" sudo iotedge system stop sudo docker rm -f edgeAgent sudo docker rm -f edgeHub sudo docker rm -f SimulatedTemperatureSensor sudo iotedge system restart sleep 120s sudo iotedge list ls -l /var/lib/aziot/edged/mnt/ curl curl --unix-socket /var/lib/aziot/edged/mnt/SimulatedTemperatureSensor.sock http://127.0.0.1 curl curl --unix-socket /var/lib/aziot/edged/mnt/edgeAgent.sock http://127.0.0.1 curl curl --unix-socket /var/lib/aziot/edged/mnt/edgeHub.sock http://127.0.0.1 echo "Test 3" sudo iotedge system stop sudo rm -r /var/lib/aziot/edged/mnt sudo iotedge system restart sleep 310s sudo iotedge list ls -l /var/lib/aziot/edged/mnt/ curl curl --unix-socket /var/lib/aziot/edged/mnt/SimulatedTemperatureSensor.sock http://127.0.0.1 curl curl --unix-socket /var/lib/aziot/edged/mnt/edgeAgent.sock http://127.0.0.1 curl curl --unix-socket /var/lib/aziot/edged/mnt/edgeHub.sock http://127.0.0.1 echo "Test 4" sudo iotedge system stop sudo docker rm -f edgeAgent sudo docker rm -f edgeHub sudo docker rm -f SimulatedTemperatureSensor sudo rm -r /var/lib/aziot/edged/mnt sudo iotedge system restart sleep 120s sudo iotedge list ls -l /var/lib/aziot/edged/mnt/ curl curl --unix-socket /var/lib/aziot/edged/mnt/SimulatedTemperatureSensor.sock http://127.0.0.1 curl curl --unix-socket /var/lib/aziot/edged/mnt/edgeAgent.sock http://127.0.0.1 curl curl --unix-socket /var/lib/aziot/edged/mnt/edgeHub.sock http://127.0.0.1 echo "Test 5" sudo iotedge system stop sudo rm /var/lib/aziot/edged/mnt/SimulatedTemperatureSensor.sock sudo rm /var/lib/aziot/edged/mnt/edgeAgent.sock sudo rm /var/lib/aziot/edged/mnt/edgeHub.sock sudo mkdir /var/lib/aziot/edged/mnt/SimulatedTemperatureSensor.sock sudo mkdir /var/lib/aziot/edged/mnt/edgeAgent.sock sudo mkdir /var/lib/aziot/edged/mnt/edgeHub.sock sudo iotedge system restart sleep 310s sudo iotedge list ls -l /var/lib/aziot/edged/mnt/ curl curl --unix-socket /var/lib/aziot/edged/mnt/SimulatedTemperatureSensor.sock http://127.0.0.1 curl curl --unix-socket /var/lib/aziot/edged/mnt/edgeAgent.sock http://127.0.0.1 curl curl --unix-socket /var/lib/aziot/edged/mnt/edgeHub.sock http://127.0.0.1 done ``` 2. Pipeline run: Package: 47895915 Run https://dev.azure.com/msazure/One/_build/results?buildId=47896816&view=results 5. Test the protection against 2 listeners: Crashed edgeAgent to have edged restart it. EdgeAgent doesn't get stopped before starting like other module: Listener EdgeAgent already started, removing old listener. Confirmed that 2 listeners is not a problem. # Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [ ] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
) (Azure#5695) After @vipeller 's PR Azure#5530, we can remove the warning suppression. # Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [X] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [X] Title of the pull request is clear and informative. - [X] Description of the pull request includes a concise summary of the enhancement or bug fix.
The Java clients do not handle the Kestrel WebSocket Ping (KeepAlive) gracefully and can put the client into a bad state. This change sets the interval to Zero which disables the WebSocket Ping (KeepAlive). This change should be safe because underlying AMQP and MQTT protocols have already built-in Keep Alive mechanisms. Also, IoT Hub does not support/send WebSocket Ping as well, that's why the issue is reproducible only with Edge Hub. The plan will be to correctly support this in the Java clients going forward but the best remediation that will have the biggest impact is to turn these off and have the edge act similarly to the hub. Cherry-pick Azure#5623
…e#5720) When edge agent creates several modules, it may send too many requests parallel to edged, which led errors in the past
…ub (Azure#5718) Iot-hub does not disconnect in case of fail over and edgeHub keeps sending messages/operations. These operations fail with a specific error and never recover. Added some logic to filter exceptions, so when the error message arrives that is thrown by the "old" server (the server serving before fail-over), EdgeHub disconnect and the new connection attempt will find the new server. cherry pick of Azure#5669
This PR Adds a Gate which triggers E2E Test Run for a Pull Request. Currently only Ubuntu 18.04 AMD64 E2E Test has been added to save time. As we optimize more, more platforms would be added 1. Added e2e-checkin.yaml. 2. Modularize images.yaml and packages.yaml to allow using build components for e2e checkin gate. 3. Add Conditions to selectively trigger Building Images and Packages. Edgelet Packages will only be built if there are changes in edgelet directory. Images will only be built if there are changes outside of test or doc directory TODO **AFTER** Merging PR 1. Add new pipeline and configure it to use e2e-checkin.yaml 2. Work with Repo Admin to add Status Check to run E2E Pipeline 3. Notify Team about Comment Triggers Testing 1. Testing was done via setting up a private pipeline : https://dev.azure.com/msazure/One/_build/results?buildId=48064485&view=results 2. As a test , created a PR to in my private fork : nimanch#4 which trigger an E2E Test run : https://dev.azure.com/msazure/One/_build/results?buildId=48067190&view=results 3. Created a dummy Pull Request to my private fork with an external alias. Verified the E2E Gate does not trigger automatically. nimanch#5 4. Created a dummy PR to my private fork with an external alias. Verified that after Commenting "/azp run" with my MSFT Github account, A Pipeline run was triggered : nimanch#6 5. Verified Existing Build Images and Build Packages Pipelines work as expected 6. Verified that existing CI E2E Test Run uses the correct artifacts ( Resource Artifacts) -> https://msazure.visualstudio.com/One/_build/results?buildId=48091890&view=logs&j=f1061aa8-bee6-5103-5b5c-2b2c91b98c58 7. Verified that an External Alias cannot trigger E2E Test Run by Commenting /azp run on the PR . nimanch#5 Testing done ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
This is a cherry pick of Azure#5692 NOTE Below are graphs with TTL 300; first is sudden burst online and second is burst offline <img width="670" alt="image" src="https://user-images.githubusercontent.com/6096983/138493452-71cce2fa-698e-4867-8fbf-1a77d6e917d7.png"> Line color change shows correct behavior of picking up where it left off <img width="680" alt="image" src="https://user-images.githubusercontent.com/6096983/138493657-256d2c7f-d4f2-49bc-be3f-c19892352443.png">
This change removes tools/IoTEdgeDevOps from the repo. It's a test dashboard that is only used internally.
) AIS recently added support for full distinguished name configuration in dynamically-generated certificates (*cf.* Azure/iot-identity-service#296, Azure/iot-identity-service#302). This PR updates the template configuration to reflect this fact. Additionally, @gordonwang0's EST documentation from the master branch is backported. ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. The tests are in the AIS repository. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. Some of the tests are still not published due to being shell scripts. They will be transitioned to pipeline tests.
Cherry-pick 76c22bf from master.
Example Run with this pipeline https://dev.azure.com/msazure/One/_build/results?buildId=48225966&view=results ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
…ure#5762) Cherry pick Azure#5749. E2E tests ran for this cherry pick to confirm the pipeline works. ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes. - Description of the pull request includes - [ ] concise summary of tests added/modified - [ ] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
…zure#5516) This commit modifies EdgeHub initialization to make sure a configuration was pulled before starting the protocol heads. *Cf.* Azure#5515.
- [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing).
… heads (Azure#5516)" (Azure#5783) This reverts commit 421aa33. There is still an interdependency between the configuration fetch task and the protocol heads in the nested case. The pertinent PR is Azure#5516. ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix.
This PR unsets executable bits for all `cs,rs,toml,yaml` files. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix.
Cherry pick Azure#5775 Waiting on this E2E test run before merge: https://dev.azure.com/msazure/One/_build/results?buildId=48525872&view=results ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
Azure#5792) Cherry pick: Azure#5774 Waiting on this e2e run before merge: https://dev.azure.com/msazure/One/_build/results?buildId=48538427&view=results ***Please replace this line with your PR description and read PR checklist below*** ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
In Certain instances, the date time generated by the Unit Test does not comply with RFC3339 Standard and hence the test fails with at a lower layer with error For example DateTime : 2021-11-03T12:07:0Z returns "Akka.Streams.Dsl.Framing+FramingException: Stream finished but there was a truncated final frame in the buffer" This is because a request is sent to management socket with the datetime in incorrect format which in turn returns a Bad Request. The fix is 2 fold 1. Fix the unit test to conform to RFC 3339 Format 2. Add checks in Managment API in Edge Agent to make sure the Since and Until Time conform to RFC3339 Standard 3. Add Unit Test for the above mentioned case Testing Done 1. Ran E2E Test Locally 2. Modified E2E Test to always use non-compliant DateTime ( Same as example above) and confirmed that test fails with same signature ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
DPS provisioning uses "attestation" field, not "authentication". ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix.
…re#5807) This is a small PR that: - adds some extra logging to MetricsValidator. This is needed to have better visibility into how long does `ValidateMetrics` take and if there are any module disconnects. - decreases Direct Method call timeout in `ValidateMetrics` test. Counterintuitively, I believe this should improve the stability of the test. Right now we use the same 5m timeout on the DM call as the whole test timeout (5m as well). Sometimes we observe that IoT Hub fails (or takes long time) to reply to Direct Method (Service API) call. Having 5m timeout on the call gives us only one chance. Reducing the timeout (to 180 sec) gives us the ability to retry one more time during the max duration of the test (5m). These change do not require test coverage. ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [X] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [X] Title of the pull request is clear and informative. - [X] Description of the pull request includes a concise summary of the enhancement or bug fix.
The fix was made in Azure#5793. Missed Enabling it in Proxy Environment E2E Pipeline run :https://dev.azure.com/msazure/One/_build/results?buildId=48715036&view=results ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
…Azure#5815) * convert to scheduled builds * Connectivity Tests: Make c2d tolerance protocol agnostic Azure#5806
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.