Skip to content

Commit

Permalink
EIP-2535: Additions and improvements (ethereum#5798)
Browse files Browse the repository at this point in the history
* EIP2535: Fixed misspelling, tweaked wording

* EIP2535: Updated dependencies

* added space

* EIP2535: Make clear that facets do not have to be reusable

* EIP-2535: additions and improvements
  • Loading branch information
mudgen authored Oct 19, 2022
1 parent e306f73 commit 07ca2ed
Show file tree
Hide file tree
Showing 3 changed files with 79 additions and 2 deletions.
3 changes: 1 addition & 2 deletions EIPS/eip-2535.md
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,7 @@ bytes4 functionSelector = bytes4(keccak256("myFunction(uint256)"));
// get facet address of function
address facet = ds.selectorToFacet[functionSelector];
bytes memory myFunctionCall = abi.encodeWithSelector(functionSelector, 4);
(bool success, uint result) = address(facet).delegatecall(myFunctionCall);
require(success, "myFunction failed");
(bool success, bytes memory result) = address(facet).delegatecall(myFunctionCall);
```
6. Instead of calling an external function defined in another facet you can instead create an internal function version of the external function. Add the internal version of the function to the facet that needs to use it.

Expand Down
78 changes: 78 additions & 0 deletions assets/eip-2535/Contributors.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
## Contributors

* Andrew Redden (@androolloyd)
* Patrick Gallagher (@pi0neerpat)
* Leo Alt (@leonardoalt)
* Santiago Palladino (@spalladino)
* William Entriken (@fulldecent)
* Gonçalo Sá (@GNSPS)
* Brian Burns (@Droopy78)
* Ramesh Nair(@hiddentao)
* Jules Goddard (@JulesGoddard)
* Micah Zoltu (@MicahZoltu)
* Sam Wilson (@SamWilsn)
* William Morriss (@wjmelements)
* Zachary (@Remscar)
* Patrick Collins (@PatrickAlphaC)
* Hadrien Croubois (@Amxx)
* (@farreldarian)
* Kelvin Schoofs (@SchoofsKelvin)
* (@0xpApaSmURf)
* Nathan Sala (@nataouze)
* Anders Torbjornsen (@anders-torbjornsen)
* (@Pandapip1)
* Xavier Iturralde (@xibot)
* Coder Dan (@cinnabarhorse)
* GldnXross (@gldnxross)
* Christian Reitwiessner (@chriseth)
* Timidan (@Timidan)
* cyotee doge (@cyotee)
* Glory Praise Emmanuel (@emmaglorypraise)
* Ed Zynda (@ezynda3)
* Arthur Nesbitt (@nesbitta)
* Cliff Hall (@cliffhall)
* Tyler Scott Ward (@tylerscottward)
* Troy Murray (@DannyDesert)
* Dan Finlay (@danfinlay)
* Theodore Georgas (@tgeorgas)
* Aditya Palepu (@apalepu23)
* Ronan Sandford (@wighawag)
* Markus Waas (@gorgos)
* Blessing Emah (@BlessingEmah)
* Andrew Edwards
* Ashwin Yardi (@ashwinYardi)
* Marco Castignoli (@marcocastignoli)
* Blaine Bublitz (@phated)
* Bearded
* Nick Barry (@ItsNickBarry)
* (@Vectorized)
* Rachit Srivastava (@rachit2501)
* Neeraj Kashyap (@zomglings)
* Zac Denham (@zdenham)
* JA (@ubinatus)
* Carter Carlson (@cartercarlson)
* James Sayer (@jamessayer98)
* Arpit Temani (@temaniarpit27)
* Parv Garg (@parv3213)
* Publius (@publiuss)
* Guy Hance (@guyhance)
* Payn (@Ayuilos)
* Luis Schliesske (@gitpusha)
* Hilmar Orth (@hilmarx)
* Matthieu Marie Joseph (@Gauddel)
* David Uzochukwu (@davidpius95)
* TJ VanSlooten (@tjvsx)
* 0xFluffyBeard (@0xFluffyBeard)
* Florian Pfeiffer (@FlorianPfeifferKanaloaNetwork)
* Mick de Graaf(@MickdeGraaf)
* Alessio Delmonti (@Alexintosh)
* Neirenoir (@Neirenoir)
* Evert Kors (@Evert0x)
* Patrick Kim (@pakim249CAL)
* Ersan YAKIT (@ersanyakit)
* Matias Arazi (@MatiArazi)
* Lucas Grasso Ramos (@LucasGrasso)
* Nikolay Angelov (@NikolayAngelov)
* John Reynolds (@gweiworld)
* Viraz Malhotra (@viraj124)
* Kemal Emre Ballı (@emrbli)
Binary file not shown.

0 comments on commit 07ca2ed

Please sign in to comment.