Fix inline case where a name was removed without the code being used, f…

…ixes davidhalter#1582
yuan-xy · May 14, 2020 · d4aa583 · d4aa583
1 parent 381fbed
commit d4aa583
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/jedi/api/refactoring/__init__.py b/jedi/api/refactoring/__init__.py
@@ -173,6 +173,8 @@ def inline(inference_state, names):
         raise RefactoringError("No definition found to inline")
     if len(definitions) > 1:
         raise RefactoringError("Cannot inline a name with multiple definitions")
+    if len(names) == 1:
+        raise RefactoringError("There are no references to this name")
 
     tree_name = definitions[0].tree_name
 

diff --git a/test/refactor/inline.py b/test/refactor/inline.py
@@ -3,6 +3,11 @@
 1
 # ++++++++++++++++++++++++++++++++++++++++++++++++++
 There is no name under the cursor
+# -------------------------------------------------- no-reference-error
+#? 0 error
+a = 1
+# ++++++++++++++++++++++++++++++++++++++++++++++++++
+There are no references to this name
 # -------------------------------------------------- multi-equal-error
 def test():
     #? 4 error