Skip to content

Commit

Permalink
Don't select the spaceview when maximizing it (rerun-io#2988)
Browse files Browse the repository at this point in the history
Closes rerun-io#2861

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2988) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2988)
- [Docs
preview](https://rerun.io/preview/pr%3Aemilk%2Fdont-select-on-maximize/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aemilk%2Fdont-select-on-maximize/examples)
  • Loading branch information
emilk authored Aug 16, 2023
1 parent ca61574 commit 1344e2a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions crates/re_viewport/src/viewport.rs
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,7 @@ impl<'a, 'b> egui_tiles::Behavior<SpaceViewId> for TabViewer<'a, 'b> {
.clicked()
{
*self.maximized = Some(space_view_id);
self.ctx
.set_single_selection(&Item::SpaceView(space_view_id));
// Just maximize - don't select. See https://github.com/rerun-io/rerun/issues/2861
}
}

Expand Down

0 comments on commit 1344e2a

Please sign in to comment.