Skip to content

Commit

Permalink
Remove setup-rust from toml lint job (rerun-io#3143)
Browse files Browse the repository at this point in the history
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

We've been using binary installs for `taplo` for quite some time.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3143) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3143)
- [Docs
preview](https://rerun.io/preview/0640ff88078f00f17ac57818f3f70a7ea014dc5f/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/0640ff88078f00f17ac57818f3f70a7ea014dc5f/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
  • Loading branch information
jprochazk authored Aug 29, 2023
1 parent dc43a39 commit 4029681
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions .github/workflows/reusable_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -225,20 +225,9 @@ jobs:
toml-lints:
name: Lint TOML files
runs-on: ubuntu-latest
env:
RUSTC_WRAPPER: "sccache"
steps:
- uses: actions/checkout@v3

- name: Set up Rust
uses: ./.github/actions/setup-rust
with:
cache_key: "build-linux"
# Cache will be produced by `reusable_checks/rs-lints`
save_cache: false
workload_identity_provider: ${{ secrets.GOOGLE_WORKLOAD_IDENTITY_PROVIDER }}
service_account: ${{ secrets.GOOGLE_SERVICE_ACCOUNT }}

- name: Install taplo-cli
uses: taiki-e/install-action@v2
with:
Expand Down Expand Up @@ -349,3 +338,4 @@ jobs:
- name: Build code examples
shell: bash
run: ./tests/cpp/build_all_doc_examples.sh --werror

0 comments on commit 4029681

Please sign in to comment.