1.10.424

[ci skip]

ccxt.js

@@ -37,7 +37,7 @@ const errors    = require ('./js/base/errors')
 //-----------------------------------------------------------------------------
 // this is updated by vss.js when building
 
-const version = '1.10.423'
+const version = '1.10.424'
 
 Exchange.ccxtVersion = version
 

ccxt.php

@@ -30,7 +30,7 @@
 
 namespace ccxt;
 
-$version = '1.10.423';
+$version = '1.10.424';
 
 define('PATH_TO_CCXT', __DIR__ . DIRECTORY_SEPARATOR . 'php' . DIRECTORY_SEPARATOR);
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "1.10.423",
+  "version": "1.10.424",
   "description": "A JavaScript / Python / PHP cryptocurrency trading library with support for 90+ exchanges",
   "main": "./ccxt.js",
   "unpkg": "build/ccxt.browser.js",

php/bitbay.php

@@ -178,9 +178,9 @@ public function create_order ($symbol, $type, $side, $amount, $price = null, $pa
         $market = $this->market ($symbol);
         return $this->privatePostTrade (array_merge (array (
             'type' => $side,
-            'currency' => $market['base'],
+            'currency' => $market['baseId'],
             'amount' => $amount,
-            'payment_currency' => $market['quote'],
+            'payment_currency' => $market['quoteId'],
             'rate' => $price,
         ), $params));
     }
@@ -200,14 +200,15 @@ public function is_fiat ($currency) {
         return false;
     }
 
-    public function withdraw ($currency, $amount, $address, $params = array ()) {
+    public function withdraw ($code, $amount, $address, $params = array ()) {
         $this->load_markets();
         $method = null;
+        $currency = $this->currency ($code);
         $request = array (
-            'currency' => $currency,
+            'currency' => $currency['id'],
             'quantity' => $amount,
         );
-        if ($this->is_fiat ($currency)) {
+        if ($this->is_fiat ($code)) {
             $method = 'privatePostWithdraw';
             // $request['account'] = $params['account']; // they demand an account number
             // $request['express'] = $params['express']; // whatever it means, they don't explain

python/ccxt/__init__.py

@@ -28,7 +28,7 @@
 
 # ----------------------------------------------------------------------------
 
-__version__ = '1.10.423'
+__version__ = '1.10.424'
 
 # ----------------------------------------------------------------------------
 

python/ccxt/async/__init__.py

@@ -4,7 +4,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.10.423'
+__version__ = '1.10.424'
 
 # -----------------------------------------------------------------------------
 

python/ccxt/async/base/exchange.py

@@ -2,7 +2,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.10.423'
+__version__ = '1.10.424'
 
 # -----------------------------------------------------------------------------
 

python/ccxt/async/bitbay.py

@@ -172,9 +172,9 @@ async def create_order(self, symbol, type, side, amount, price=None, params={}):
         market = self.market(symbol)
         return self.privatePostTrade(self.extend({
             'type': side,
-            'currency': market['base'],
+            'currency': market['baseId'],
             'amount': amount,
-            'payment_currency': market['quote'],
+            'payment_currency': market['quoteId'],
             'rate': price,
         }, params))
 
@@ -191,14 +191,15 @@ def is_fiat(self, currency):
             return True
         return False
 
-    async def withdraw(self, currency, amount, address, params={}):
+    async def withdraw(self, code, amount, address, params={}):
         await self.load_markets()
         method = None
+        currency = self.currency(code)
         request = {
-            'currency': currency,
+            'currency': currency['id'],
             'quantity': amount,
         }
-        if self.is_fiat(currency):
+        if self.is_fiat(code):
             method = 'privatePostWithdraw'
             # request['account'] = params['account']  # they demand an account number
             # request['express'] = params['express']  # whatever it means, they don't explain

python/ccxt/base/exchange.py

@@ -4,7 +4,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.10.423'
+__version__ = '1.10.424'
 
 # -----------------------------------------------------------------------------
 

python/ccxt/bitbay.py

@@ -172,9 +172,9 @@ def create_order(self, symbol, type, side, amount, price=None, params={}):
         market = self.market(symbol)
         return self.privatePostTrade(self.extend({
             'type': side,
-            'currency': market['base'],
+            'currency': market['baseId'],
             'amount': amount,
-            'payment_currency': market['quote'],
+            'payment_currency': market['quoteId'],
             'rate': price,
         }, params))
 
@@ -191,14 +191,15 @@ def is_fiat(self, currency):
             return True
         return False
 
-    def withdraw(self, currency, amount, address, params={}):
+    def withdraw(self, code, amount, address, params={}):
         self.load_markets()
         method = None
+        currency = self.currency(code)
         request = {
-            'currency': currency,
+            'currency': currency['id'],
             'quantity': amount,
         }
-        if self.is_fiat(currency):
+        if self.is_fiat(code):
             method = 'privatePostWithdraw'
             # request['account'] = params['account']  # they demand an account number
             # request['express'] = params['express']  # whatever it means, they don't explain