Translate error messages from CreateEvaluationCriterion mutation (pup…

…ilfirst#1512) Co-authored-by: Hari Gopal <[email protected]>
yuanzhongqiao · Dec 6, 2023 · 049922e · 049922e
1 parent 47c7d77
commit 049922e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/app/queries/create_evaluation_criterion_mutator.rb b/app/queries/create_evaluation_criterion_mutator.rb
@@ -28,14 +28,14 @@ def unique_name_and_grade_params
 
     errors.add(
       :base,
-      'Criterion already exists with same name, max grade and pass grade'
+      I18n.t('mutations.evaluation_criterion.name_exists')
     )
   end
 
   def course_must_be_present
     return if course.present?
 
-    errors.add(:base, "Course with ID #{course_id} does not exist")
+    errors.add(:base, I18n.t("mutations.evaluation_criterion.no_course", course_id: course.id))
   end
 
   def create_evaluation_criterion

diff --git a/config/locales/ar.yml b/config/locales/ar.yml
@@ -2277,6 +2277,9 @@ ar:
       course_not_found_error: Could not find a course with the given ID
       success_notification: Your export is being processed. We'll notify you as soon as it is ready.
       tag_not_found_error: Could not find tags with the given IDs
+    evaluation_criterion:
+      name_exists: اسم المعيار موجود مسبقاً
+      no_course: لا توجد دورة تحمل الرقم %{course_id}
     initiate_account_deletion:
       check_inbox_notification: Check your inbox for further steps!
       deletion_init_notification: Account Deletion Initiated

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -2304,6 +2304,9 @@ en:
       course_not_found_error: Could not find a course with the given ID
       success_notification: Your export is being processed. We'll notify you as soon as it is ready.
       tag_not_found_error: Could not find tags with the given IDs
+    evaluation_criterion:
+      name_exists: A criterion already exists with this name and maximum grade.
+      no_course: Course with ID %{course_id} does not exist; please reload this page before trying again.
     initiate_account_deletion:
       check_inbox_notification: Check your inbox for further steps!
       deletion_init_notification: Account Deletion Initiated

diff --git a/spec/system/school/courses/evaluation_criteria_index_spec.rb b/spec/system/school/courses/evaluation_criteria_index_spec.rb
@@ -119,7 +119,7 @@ def label_for_grade(grade_labels, grade)
     select evaluation_criterion_1.max_grade, from: 'max_grade'
 
     click_button 'Create Criterion'
-    expect(page).to have_text("Criterion already exists with same name, max grade and pass grade")
+    expect(page).to have_text("A criterion already exists with this name and maximum grade")
   end
 
   scenario 'course author creates and edits a criterion' do