Fix buggy html

yue · Feb 28, 2019 · cd0e336 · cd0e336
1 parent 7aa55fb
commit cd0e336
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/service/slack/message-parser.js b/lib/service/slack/message-parser.js
@@ -1,4 +1,5 @@
 const stringReplaceAsync = require('string-replace-async')
+const sanitizeHtml = require('sanitize-html')
 
 const emoji = require('./emoji.json')
 
@@ -125,7 +126,10 @@ function parseMarkdown(account, text) {
     start = preIndex + 3
   }
   newText += runRules(account, text.substr(start).trimLeft())
-  return newText
+
+  // Our parser is buggy, and sometimes HTML passed from Slack is also bug, the
+  // easist way to fix this is to run sanitizeHtml.
+  return sanitizeHtml(newText, {allowedTags: false, allowedAttributes: false})
 }
 
 function slackMarkdownToHtmlSync(account, text) {

diff --git a/package.json b/package.json
@@ -38,14 +38,15 @@
     "download-yue": "2.x",
     "fetch-yode": "0.2.0",
     "fs-extra": "5.0.0",
-    "gui": "0.5.3",
+    "gui": "0.6.3",
     "keytar": "4.3.0",
     "mini-signals": "1.1.1",
     "opn": "5.3.0",
     "readable-size": "0.2.0",
+    "sanitize-html": "1.20.0",
     "string-replace-async": "1.2.1"
   },
   "devDependencies": {
-    "yackage": "0.2.8"
+    "yackage": "0.2.9"
   }
 }