Update fastlane and remove workaround

Gemfile.lock

@@ -10,8 +10,8 @@ GEM
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-    addressable (2.8.6)
-      public_suffix (>= 2.0.2, < 6.0)
+    addressable (2.8.7)
+      public_suffix (>= 2.0.2, < 7.0)
     algoliasearch (1.27.5)
       httpclient (~> 2.8, >= 2.8.3)
       json (>= 1.5.1)
@@ -20,17 +20,17 @@ GEM
     artifactory (3.0.17)
     atomos (0.1.3)
     aws-eventstream (1.3.0)
-    aws-partitions (1.944.0)
-    aws-sdk-core (3.197.0)
+    aws-partitions (1.948.0)
+    aws-sdk-core (3.199.0)
       aws-eventstream (~> 1, >= 1.3.0)
       aws-partitions (~> 1, >= 1.651.0)
       aws-sigv4 (~> 1.8)
       jmespath (~> 1, >= 1.6.1)
-    aws-sdk-kms (1.85.0)
-      aws-sdk-core (~> 3, >= 3.197.0)
+    aws-sdk-kms (1.87.0)
+      aws-sdk-core (~> 3, >= 3.199.0)
       aws-sigv4 (~> 1.1)
-    aws-sdk-s3 (1.152.3)
-      aws-sdk-core (~> 3, >= 3.197.0)
+    aws-sdk-s3 (1.154.0)
+      aws-sdk-core (~> 3, >= 3.199.0)
       aws-sdk-kms (~> 1)
       aws-sigv4 (~> 1.8)
     aws-sigv4 (1.8.0)
@@ -119,7 +119,7 @@ GEM
     faraday_middleware (1.2.0)
       faraday (~> 1.0)
     fastimage (2.3.1)
-    fastlane (2.221.0)
+    fastlane (2.221.1)
       CFPropertyList (>= 2.3, < 4.0.0)
       addressable (>= 2.8, < 3.0.0)
       artifactory (~> 3.0)

fastlane/Fastfile

@@ -239,35 +239,27 @@ platform :ios do
         }
     )
 
-    begin
-      upload_to_testflight(
-          api_key_path: "./ios/ios-fastlane-json-key.json",
-          distribute_external: true,
-          notify_external_testers: true,
-          changelog: "Thank you for beta testing New Expensify, this version includes bug fixes and improvements.",
-          groups: ["Beta"],
-          demo_account_required: true,
-          beta_app_review_info: {
-              contact_email: ENV["APPLE_CONTACT_EMAIL"],
-              contact_first_name: "Andrew",
-              contact_last_name: "Gable",
-              contact_phone: ENV["APPLE_CONTACT_PHONE"],
-              demo_account_name: ENV["APPLE_DEMO_EMAIL"],
-              demo_account_password: ENV["APPLE_DEMO_PASSWORD"],
-              notes: "1. In the Expensify app, enter the email '[email protected]'. This will trigger a sign-in link to be sent to '[email protected]'
-                      2. Navigate to https://account.proton.me/login, log into Proton Mail using '[email protected]' as email and the password associated with '[email protected]', provided above
-                      3. Once logged into Proton Mail, navigate to your inbox and locate the email triggered in step 1. The email subject should be 'Your magic sign-in link for Expensify'
-                      4. Open the email and copy the 6-digit sign-in code provided within
-                      5. Return to the Expensify app and enter the copied 6-digit code in the designated login field"
-          }
-      )
-    rescue Exception => e
-      if e.message.include? "Another build is in review"
-        UI.important("Another build is already in external beta review. Skipping external beta review submission")
-      else
-        raise
-      end
-    end
+    upload_to_testflight(
+      api_key_path: "./ios/ios-fastlane-json-key.json",
+      distribute_external: true,
+      notify_external_testers: true,
+      changelog: "Thank you for beta testing New Expensify, this version includes bug fixes and improvements.",
+      groups: ["Beta"],
+      demo_account_required: true,
+      beta_app_review_info: {
+          contact_email: ENV["APPLE_CONTACT_EMAIL"],
+          contact_first_name: "Andrew",
+          contact_last_name: "Gable",
+          contact_phone: ENV["APPLE_CONTACT_PHONE"],
+          demo_account_name: ENV["APPLE_DEMO_EMAIL"],
+          demo_account_password: ENV["APPLE_DEMO_PASSWORD"],
+          notes: "1. In the Expensify app, enter the email '[email protected]'. This will trigger a sign-in link to be sent to '[email protected]'
+                  2. Navigate to https://account.proton.me/login, log into Proton Mail using '[email protected]' as email and the password associated with '[email protected]', provided above
+                  3. Once logged into Proton Mail, navigate to your inbox and locate the email triggered in step 1. The email subject should be 'Your magic sign-in link for Expensify'
+                  4. Open the email and copy the 6-digit sign-in code provided within
+                  5. Return to the Expensify app and enter the copied 6-digit code in the designated login field"
+      }
+    )
 
     upload_symbols_to_crashlytics(
       app_id: "1:921154746561:ios:216bd10ccc947659027c40",