Skip to content

Commit

Permalink
Revert "Use -fprofile-use= when TEST_SUITE_USE_IR_PGO is enabled"
Browse files Browse the repository at this point in the history
This reverts commit c1ea19f.

It looks like this is passing the wrong paths to -fprofile-instr-use
now. Previously it passed ${target_path}.profdata.

The new path (${TEST_SUITE_PROFILE_PATH}/${target}.profdat) doesn't
point to the correct location when building via LNT in some
configurations.

Reverting for now to get bots back to green.
  • Loading branch information
fhahn committed Sep 30, 2022
1 parent c1ea19f commit d66d506
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions cmake/modules/TestSuite.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,8 @@ function(llvm_test_executable_no_test target)
append_target_flags(LINK_LIBRARIES ${target} ${LDFLAGS})
set(target_path ${CMAKE_CURRENT_BINARY_DIR}/${target})
if(TEST_SUITE_PROFILE_USE)
if(TEST_SUITE_USE_IR_PGO)
append_target_flags(COMPILE_FLAGS ${target} -fprofile-use=${TEST_SUITE_PROFILE_PATH}/${target}.profdata)
append_target_flags(LINK_LIBRARIES ${target} -fprofile-use=${TEST_SUITE_PROFILE_PATH}/${target}.profdata)
else()
append_target_flags(COMPILE_FLAGS ${target} -fprofile-instr-use=${TEST_SUITE_PROFILE_PATH}/${target}.profdata)
append_target_flags(LINK_LIBRARIES ${target} -fprofile-instr-use=${TEST_SUITE_PROFILE_PATH}/${target}.profdata)
endif()
append_target_flags(COMPILE_FLAGS ${target} -fprofile-instr-use=${target_path}.profdata)
append_target_flags(LINK_LIBRARIES ${target} -fprofile-instr-use=${target_path}.profdata)
endif()

llvm_codesign(${target})
Expand Down

0 comments on commit d66d506

Please sign in to comment.