Chore embed crummy-test in crummy #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this commit can be reverted safely.
Note: crummy-test@421da01b7f21ef0ad8b7200aa4add17291ab0e2b See https://github.com/zachinglis/crummy-test
You may want to use a distinct gemset from that of the gem. I do. Note: this commit can be reverted safely.
This is what makes the example app a good test app.
The gem README is written in markdown.
Mainly to keep example/Gemfile.lock under version control. See http://gembundler.com/ Gemfile.lock-related section Note: if you really don't want that, this commit can be reverted safely.
Note: I did this to check I didn't break anything before opening a pull request. This commit can be reverted safely.
|
Looks good, thanks so much! I'll also add you as a contributor to the project |
andrew
added a commit
that referenced
this pull request
Mar 4, 2013
…-crummy Chore embed crummy-test in crummy
|
Hi @andrew , glad that was useful, thanks for the push access! |
|
@gonzalo-bulnes Seriously appreciated :) Something I've wanted to do for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zachinglis ! Yesterday, taking a look at Crummy I read what you had written in the Crummy-test about not having found a satisfactory way to test your gem from inside. I also read some posts you wrote about learning and teaching, and I liked them.
A few weeks ago, I saw an example app embedded into a gem (TBK) and I found that quite clean. I liked the idea, some aspects of some gems just can't be tested without an app. The example app becomes part of the documentation or part of the test suite and can be maintained as so. Debugging also becomes a lot less painful without the need to bump versions for any change.
If you hadn't seen this done before, here is an example, I hope it'll help you.