authhelper: record/report local/session storage #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
reviewed
Mar 6, 2025
Comment on lines
207
to
224
| """ | ||
| const data = []; | ||
| for (let i = 0; i < window.localStorage.length; i++) { | ||
| data.push({"key": window.localStorage.key(i), "value": window.localStorage.getItem(window.localStorage.key(i))}); | ||
| } | ||
| return data; | ||
| """, | ||
| DiagnosticBrowserStorageItem.Type.LOCAL); | ||
|
|
||
| processStorage( | ||
| je, | ||
| """ | ||
| const data = []; | ||
| for (let i = 0; i < sessionStorage.length; i++) { | ||
| data.push({"key": sessionStorage.key(i), "value": sessionStorage.getItem(sessionStorage.key(i))}); | ||
| } | ||
| return data; | ||
| """, |
There was a problem hiding this comment.
Use a single or constant string and a variable for the storage type/location and insert it via format?
There was a problem hiding this comment.
Not 100% sure this is what you meant but it addresses the duplication.
|
Great job, no security vulnerabilities found in this Pull Request |
thc202
force-pushed
the
authhelper/diags-storage
branch
from
9adf5a5 to
ce6d902
Compare
Record and report the state of the local/session storage for the authentication diagnostics. Signed-off-by: thc202 <[email protected]>
thc202
force-pushed
the
authhelper/diags-storage
branch
from
ce6d902 to
def771d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record and report the state of the local/session storage for the authentication diagnostics.